Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image tests from placeholder.com to *.vercel.app #38081

Merged
merged 2 commits into from Jun 28, 2022
Merged

Update image tests from placeholder.com to *.vercel.app #38081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13fc1cb
Update image tests from placeholder.com to *.vercel.app
styfle Jun 28, 2022
112514a
Merge branch 'canary' into switch-image-placeholder-to-vercel-app
kodiakhq[bot] Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration/image-component/unoptimized/pages/index.js
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ const Page = () => {
<br />
<Image
id="external-image"
src="https://via.placeholder.com/800/000/FFF.png?text=test"
src="https://image-optimization-test.vercel.app/test.jpg"
width={400}
height={400}
/>
Expand Down
8 changes: 4 additions & 4 deletions test/integration/image-component/unoptimized/test/index.test.js
View file
Open in desktop
Expand Up @@ -61,23 +61,23 @@ function runTests() {
await check(
() =>
browser.eval(`document.getElementById("external-image").currentSrc`),
/placeholder.com/
'https://image-optimization-test.vercel.app/test.jpg'
)
await check(
() => browser.elementById('internal-image').getAttribute('src'),
/test\.png/
'/test.png'
)
await check(
() => browser.elementById('static-image').getAttribute('src'),
/test(.*)jpg/
)
await check(
() => browser.elementById('external-image').getAttribute('src'),
/https:\/\/via\.placeholder\.com\/800\/000\/FFF\.png\?text=test/
'https://image-optimization-test.vercel.app/test.jpg'
)
await check(
() => browser.elementById('eager-image').getAttribute('src'),
/test\.webp/
'/test.webp'
)

expect(
Expand Down
2 changes: 1 addition & 1 deletion test/integration/image-future/unoptimized/pages/index.js
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ const Page = () => {
<br />
<Image
id="external-image"
src="https://via.placeholder.com/800/000/FFF.png?text=test"
src="https://image-optimization-test.vercel.app/test.jpg"
width={400}
height={400}
/>
Expand Down
6 changes: 3 additions & 3 deletions test/integration/image-future/unoptimized/test/index.test.js
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ function runTests() {
).toMatch(/test(.*)jpg/)
expect(
await browser.elementById('external-image').getAttribute('src')
).toBe('https://via.placeholder.com/800/000/FFF.png?text=test')
).toBe('https://image-optimization-test.vercel.app/test.jpg')
expect(await browser.elementById('eager-image').getAttribute('src')).toBe(
'/test.webp'
)
Expand Down Expand Up @@ -61,7 +61,7 @@ function runTests() {
await check(
() =>
browser.eval(`document.getElementById("external-image").currentSrc`),
/placeholder.com/
'https://image-optimization-test.vercel.app/test.jpg'
)

expect(
Expand All @@ -72,7 +72,7 @@ function runTests() {
).toMatch(/test(.*)jpg/)
expect(
await browser.elementById('external-image').getAttribute('src')
).toBe('https://via.placeholder.com/800/000/FFF.png?text=test')
).toBe('https://image-optimization-test.vercel.app/test.jpg')
expect(await browser.elementById('eager-image').getAttribute('src')).toBe(
'/test.webp'
)
Expand Down