Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix experimental remotePatterns wildcard #37137

Merged
merged 5 commits into from May 25, 2022
Merged

Fix experimental remotePatterns wildcard #37137

merged 5 commits into from May 25, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented May 23, 2022 •
edited

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 23, 2022
styfle
styfle commented May 23, 2022
View reviewed changes
packages/next/build/index.ts Outdated Show resolved Hide resolved
@ijjk

This comment was marked as outdated.

Sign in to view
@ijjk
Copy link
Member

ijjk commented May 23, 2022 •
edited

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
buildDuration 15.6s 15.7s ⚠️ +133ms
buildDurationCached 6.2s 6.3s ⚠️ +102ms
nodeModulesSize 494 MB 494 MB -2.23 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.74 3.845 ⚠️ +0.1
/ avg req/sec 668.52 650.23 ⚠️ -18.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.324 1.318 -0.01
/error-in-render avg req/sec 1888.29 1896.38 +8.09
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 73 kB 73 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.74 kB 5.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
buildDuration 18.1s 17.8s -307ms
buildDurationCached 6.3s 6.4s ⚠️ +11ms
nodeModulesSize 494 MB 494 MB -2.23 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.891 3.851 -0.04
/ avg req/sec 642.51 649.11 +6.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.357 1.305 -0.05
/error-in-render avg req/sec 1842.05 1916.16 +74.11
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.7 kB 29.7 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.84 kB 5.84 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.78 kB 2.78 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.4 kB 16.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js use-micromatch-regex-remote-patterns Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 529 B 529 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 718f905

ijjk
ijjk previously approved these changes May 24, 2022
View reviewed changes
@styfle styfle requested a review from ijjk May 25, 2022 02:48
@styfle styfle marked this pull request as ready for review May 25, 2022 18:43
@kodiakhq kodiakhq bot merged commit 0d95886 into canary May 25, 2022
@kodiakhq kodiakhq bot deleted the use-micromatch-regex-remote-patterns branch May 25, 2022 20:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@styfle @ijjk