Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interopDefault on jest object-proxy #37002

Merged
merged 2 commits into from May 18, 2022
Merged

Fix interopDefault on jest object-proxy #37002

merged 2 commits into from May 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 18, 2022

This fixes the interop default from #36877 on the jest object-proxy as it currently causes the below error when running tests in our with-jest example:

    TypeError: 'get' on proxy: property '__esModule' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected 'true' but got 'false')

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: #36877

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 18, 2022
@ijjk
Copy link
Member Author

ijjk commented May 18, 2022 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
buildDuration 14.4s 14.1s -272ms
buildDurationCached 5.8s 5.7s -141ms
nodeModulesSize 478 MB 478 MB ⚠️ +2.09 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.5 3.488 -0.01
/ avg req/sec 714.27 716.82 +2.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.23 1.213 -0.02
/error-in-render avg req/sec 2032.12 2061.37 +29.25
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.7 kB 28.8 kB ⚠️ +24 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.4 kB 72.4 kB ⚠️ +24 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.7 kB 2.71 kB ⚠️ +6 B
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.71 kB 5.72 kB ⚠️ +8 B
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ⚠️ +7 B
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15.9 kB 16 kB ⚠️ +21 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
_buildManifest.js gzip 458 B 460 B ⚠️ +2 B
Overall change 458 B 460 B ⚠️ +2 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
index.html gzip 532 B 531 B -1 B
link.html gzip 544 B 545 B ⚠️ +1 B
withRouter.html gzip 528 B 528 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for _buildManifest.js 
@@ -8,12 +8,12 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-436fa6bb26fc4120.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-a714d10b912e5a04.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-166cebe56831487c.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-6d25f8059d21ea6e.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-9ccd1df3f88508f7.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-e9333123dfdaa509.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-14cc686179ced0b5.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
Diff for dynamic-HASH.js 
@@ -157,8 +157,9 @@
         };
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for image-HASH.js 
@@ -1105,8 +1105,9 @@
           .concat(quality || 75);
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1319,8 +1320,9 @@
         return instance;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for link-HASH.js 
@@ -405,8 +405,9 @@
       var _default = Link;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -619,8 +620,9 @@
         return instance;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for main-HASH.js 
@@ -241,8 +241,9 @@
         ).toString();
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1552,8 +1553,9 @@
         return null;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1584,8 +1586,9 @@
         })
         .catch(console.error);
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1611,8 +1614,9 @@
       var normalizePathTrailingSlash = false ? 0 : removePathTrailingSlash;
       exports.normalizePathTrailingSlash = normalizePathTrailingSlash;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1802,8 +1806,9 @@
       })();
       exports["default"] = PageLoader;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1855,8 +1860,9 @@
       };
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1973,8 +1979,9 @@
       };
       exports.Portal = Portal;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2018,8 +2025,9 @@
         };
       exports.cancelIdleCallback = cancelIdleCallback;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2173,8 +2181,9 @@
       var _default = RouteAnnouncer;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2580,8 +2589,9 @@
         };
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2906,8 +2916,9 @@
         return instance;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3304,8 +3315,9 @@
       var _default = Script;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3332,8 +3344,9 @@
         return (0, _react).useContext(RefreshContext);
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3388,8 +3401,9 @@
         );
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3438,8 +3452,9 @@
             };
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3772,8 +3787,9 @@
         );
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -4080,8 +4096,9 @@
       var _default = Head;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-157d3228bb171564.js"
+      src="/_next/static/chunks/main-024612d9e37f655a.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-157d3228bb171564.js"
+      src="/_next/static/chunks/main-024612d9e37f655a.js"
       defer=""
     ></script>
     <script
@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-9ccd1df3f88508f7.js"
+      src="/_next/static/chunks/pages/link-14cc686179ced0b5.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-157d3228bb171564.js"
+      src="/_next/static/chunks/main-024612d9e37f655a.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
buildDuration 16.1s 16.2s ⚠️ +137ms
buildDurationCached 5.8s 5.8s -48ms
nodeModulesSize 478 MB 478 MB ⚠️ +2.09 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.529 3.493 -0.04
/ avg req/sec 708.33 715.65 +7.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.227 1.24 ⚠️ +0.01
/error-in-render avg req/sec 2037.01 2015.8 ⚠️ -21.21
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ⚠️ +22 B
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 73.5 kB 73.5 kB ⚠️ +22 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ⚠️ +1 B
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.8 kB 5.81 kB ⚠️ +9 B
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.77 kB 2.78 kB ⚠️ +7 B
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ⚠️ +17 B
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/proxy-interop-default Change
index.html gzip 532 B 531 B -1 B
link.html gzip 547 B 546 B -1 B
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.6 kB -2 B

Diffs

Diff for _buildManifest.js 
@@ -8,12 +8,12 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fcss-436fa6bb26fc4120.js"
   ],
   "/dynamic": [
-    "static\u002Fchunks\u002Fpages\u002Fdynamic-a714d10b912e5a04.js"
+    "static\u002Fchunks\u002Fpages\u002Fdynamic-166cebe56831487c.js"
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-544bb68363445a0e.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-c1372eeb4916d32c.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-6d25f8059d21ea6e.js"],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-9ccd1df3f88508f7.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-e9333123dfdaa509.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-14cc686179ced0b5.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-113a7082ae16fbcb.js"
   ],
Diff for dynamic-HASH.js 
@@ -157,8 +157,9 @@
         };
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for image-HASH.js 
@@ -1105,8 +1105,9 @@
           .concat(quality || 75);
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1319,8 +1320,9 @@
         return instance;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for link-HASH.js 
@@ -405,8 +405,9 @@
       var _default = Link;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -619,8 +620,9 @@
         return instance;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for main-HASH.js 
@@ -241,8 +241,9 @@
         ).toString();
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1552,8 +1553,9 @@
         return null;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1584,8 +1586,9 @@
         })
         .catch(console.error);
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1611,8 +1614,9 @@
       var normalizePathTrailingSlash = false ? 0 : removePathTrailingSlash;
       exports.normalizePathTrailingSlash = normalizePathTrailingSlash;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1802,8 +1806,9 @@
       })();
       exports["default"] = PageLoader;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1855,8 +1860,9 @@
       };
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -1973,8 +1979,9 @@
       };
       exports.Portal = Portal;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2018,8 +2025,9 @@
         };
       exports.cancelIdleCallback = cancelIdleCallback;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2173,8 +2181,9 @@
       var _default = RouteAnnouncer;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2580,8 +2589,9 @@
         };
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -2906,8 +2916,9 @@
         return instance;
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3304,8 +3315,9 @@
       var _default = Script;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3332,8 +3344,9 @@
         return (0, _react).useContext(RefreshContext);
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3388,8 +3401,9 @@
         );
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3438,8 +3452,9 @@
             };
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -3772,8 +3787,9 @@
         );
       }
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
@@ -4080,8 +4096,9 @@
       var _default = Head;
       exports["default"] = _default;
       if (
-        typeof exports.default === "function" ||
-        (typeof exports.default === "object" && exports.default !== null)
+        (typeof exports.default === "function" ||
+          (typeof exports.default === "object" && exports.default !== null)) &&
+        typeof exports.default.__esModule === "undefined"
       ) {
         Object.defineProperty(exports.default, "__esModule", {
           value: true
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-157d3228bb171564.js"
+      src="/_next/static/chunks/main-024612d9e37f655a.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-157d3228bb171564.js"
+      src="/_next/static/chunks/main-024612d9e37f655a.js"
       defer=""
     ></script>
     <script
@@ -27,7 +27,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-9ccd1df3f88508f7.js"
+      src="/_next/static/chunks/pages/link-14cc686179ced0b5.js"
       defer=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" defer=""></script>
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-157d3228bb171564.js"
+      src="/_next/static/chunks/main-024612d9e37f655a.js"
       defer=""
     ></script>
     <script
Commit: 27dd4a8

@ijjk ijjk marked this pull request as ready for review May 18, 2022 01:33
@ijjk ijjk requested a review from Brooooooklyn May 18, 2022 01:33
SukkaW
SukkaW suggested changes May 18, 2022
View reviewed changes
packages/next/taskfile-swc.js Outdated Show resolved Hide resolved
@ijjk @SukkaW
Apply suggestions from code review
27dd4a8 
Co-authored-by: Sukka <isukkaw@gmail.com>
@kodiakhq kodiakhq bot merged commit f3c3113 into vercel:canary May 18, 2022
@ijjk ijjk deleted the fix/proxy-interop-default branch May 18, 2022 14:02
SukkaW pushed a commit to SukkaW/next.js that referenced this pull request May 18, 2022
@ijjk @SukkaW
Fix interopDefault on jest object-proxy (vercel#37002)
60dca6f 
This fixes the interop default from vercel#36877 on the jest `object-proxy` as it currently causes the below error when running tests in our `with-jest` example:

```sh
    TypeError: 'get' on proxy: property '__esModule' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected 'true' but got 'false')
```

## Bug

- [ ] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

x-ref: vercel#36877
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SukkaW SukkaW SukkaW requested changes

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@timneutkens timneutkens timneutkens approved these changes

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ijjk @Brooooooklyn @timneutkens @SukkaW