Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graceful shutdowns #36909

Merged
merged 8 commits into from May 16, 2022
Merged

Support graceful shutdowns #36909

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f8de511
feat(next): Support graceful shutdowns
sidwebworks May 14, 2022
dea6adf
Merge branch 'vercel:canary' into canary
sidwebworks May 15, 2022
02ae173
fix(next): remove graceful shutdown timeout
sidwebworks May 15, 2022
4287d15
Merge branch 'canary' of github.com:sidwebworks/next.js into canary
sidwebworks May 15, 2022
e3b7b23
fix(next): register SIGINT handler conditionally
sidwebworks May 15, 2022
8f0540d
docs(next): Add section for graceful shutdowns
sidwebworks May 15, 2022
66ba59f
fix(docs): undo note section removal
sidwebworks May 15, 2022
a4e48a1
Merge branch 'canary' into canary
ijjk May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/next/bin/next.ts
View file
Open in desktop
Expand Up @@ -129,7 +129,16 @@ if (process.versions.pnp === '3') {
}

// Make sure commands gracefully respect termination signals (e.g. from Docker)
process.on('SIGTERM', () => process.exit(0))
// Allow the graceful termination to be manually configurable
if (!process.env.NEXT_MANUAL_SIGTERM) {
process.on('SIGTERM', () =>
setTimeout(
() => process.exit(0),
parseInt(process.env.NEXT_GRACEFUL_SHUTDOWN_TIMEOUT_MS || '0', 10)
ijjk marked this conversation as resolved.
Show resolved Hide resolved
)
ijjk marked this conversation as resolved.
Show resolved Hide resolved
)
}

process.on('SIGINT', () => process.exit(0))

commands[command]()
Expand Down