Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adding changes to setCookie example #36870

Merged
merged 2 commits into from May 13, 2022
Merged

docs: adding changes to setCookie example #36870

merged 2 commits into from May 13, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2022 •
edited by balazsorban44

fixes #28453

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ghost ghost mentioned this pull request May 12, 2022
Closed
@balazsorban44 balazsorban44 changed the title fixes #28453; docs: adding changes to setCookie example docs: adding changes to setCookie example May 13, 2022
@kodiakhq kodiakhq bot merged commit 3674cad into vercel:canary May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setCookie example in docs incorrectly handles expires and maxAge
2 participants
@balazsorban44 @ijjk