Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade dependencies in Jest examples #36858

Merged
merged 1 commit into from May 12, 2022
Merged

chore: upgrade dependencies in Jest examples #36858

merged 1 commit into from May 12, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented May 12, 2022 •
edited

Ref: #36842, #36632, #36787

Upgrading to Jest 28, and aligning Babel example with with-jest

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label May 12, 2022
ijjk
ijjk approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although we might also want to update the snapshot as it fails on initial run for both examples:

Screen Shot 2022-05-12 at 10 34 45 AM

@kodiakhq kodiakhq bot merged commit b596ce9 into canary May 12, 2022
@kodiakhq kodiakhq bot deleted the examples/with-jest branch May 12, 2022 15:37
@balazsorban44 balazsorban44 mentioned this pull request May 13, 2022
Merged
10 tasks
kodiakhq bot pushed a commit that referenced this pull request May 13, 2022
@balazsorban44
chore: update Jest example snapshots (#36884)
2ed5b3d 
Follow-up: #36858 (review)

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balazsorban44 @ijjk