Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leftover todo in loader #36734

Merged
merged 1 commit into from May 6, 2022
Merged

Fix leftover todo in loader #36734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/next/build/entries.ts
View file
Open in desktop
Expand Up @@ -366,11 +366,6 @@ export async function createEntrypoints(params: CreateEntrypointsParams) {
const getEntryHandler =
(mappings: Record<string, string>, isViews: boolean) =>
async (page: string) => {
// TODO: @timneutkens do not pass layouts to entry here
if (isViews && page.endsWith('/layout')) {
return
}

const bundleFile = normalizePagePath(page)
const clientBundlePath = posix.join('pages', bundleFile)
const serverBundlePath = posix.join(
Expand Down
3 changes: 2 additions & 1 deletion packages/next/build/index.ts
View file
Open in desktop
Expand Up @@ -318,10 +318,11 @@ export default async function build(
.traceAsyncFn(() =>
recursiveReadDir(
viewsDir,
new RegExp(`\\.(?:${config.pageExtensions.join('|')})$`)
new RegExp(`page\\.(?:${config.pageExtensions.join('|')})$`)
)
)
}

// needed for static exporting since we want to replace with HTML
// files

Expand Down