Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples to use React 18 #36378

Closed
wants to merge 3 commits into from
Closed

Update examples to use React 18 #36378

wants to merge 3 commits into from

Conversation

buzuosheng
Copy link

Update repo to use react 18 by default: #35888

@ijjk ijjk added the examples Issue/PR related to examples label Apr 22, 2022
balazsorban44
balazsorban44 approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

balazsorban44
balazsorban44 previously approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shfshanyue
Copy link

Thanks，it's helpful to me, and when to merge it.

@balazsorban44
Copy link
Member

There is a new version (18.1.0) out, could you update to that and fix the merge conflicts? I can re-approve after that. 👍

@buzuosheng
Copy link
Author

buzuosheng commented May 18, 2022 •
edited

I've done this.

@balazsorban44
Copy link
Member

@buzuosheng 18.2.0 is out now, could you update again and resolve merge conflicts, and ping me, and I'll try to merge this as quickly as possible to avoid conflicts with other PRs changing the examples folder?

@ijjk ijjk added the type: next label Sep 9, 2022
@balazsorban44
Copy link
Member

Given the high likelihood of merge conflicts, let's address this gradually rather than in one PR. Examples should ideally be tested when these dependencies are updated. 👍 Thanks for working on this anyway! 🙏 💚

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
examples Issue/PR related to examples type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@buzuosheng @shfshanyue @balazsorban44 @ijjk