Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for catch-all route params in NextRequest page type declaration #36137

Merged
merged 2 commits into from Apr 13, 2022
Merged

Add support for catch-all route params in NextRequest page type declaration #36137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d24d338
Add support for catch-all route params in NextRequest page type decla…
prichey Apr 13, 2022
1ce2cfe
Merge branch 'canary' into prichey/fix-nextrequest-page-params-type
prichey Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/server/web/spec-extension/request.ts
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ export class NextRequest extends Request {
cookieParser(): { [key: string]: string }
geo: RequestData['geo']
ip?: string
page?: { name?: string; params?: { [key: string]: string } }
page?: { name?: string; params?: { [key: string]: string | string[] } }
ua?: UserAgent | null
url: NextURL
}
Expand Down Expand Up @@ -105,7 +105,7 @@ export interface RequestInit extends globalThis.RequestInit {
}
page?: {
name?: string
params?: { [key: string]: string }
params?: { [key: string]: string | string[] }
}
}

Expand Down