Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate @types/react by fs API as it has exports fields #36094

Closed
wants to merge 1 commit into from

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Apr 12, 2022

@types/react published with exports field in package.json.

The require.resolve('@react/types/index.d.ts') expression will throw with Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './index.d.ts' is not defined by "exports" in /Users/longyinan/workspace/test/with-typescript-app/node_modules/@types/react/package.json

fixes #36085

@ijjk
Copy link
Member

ijjk commented Apr 12, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
buildDuration 19.9s 20.4s ⚠️ +588ms
buildDurationCached 8.1s 7.8s -371ms
nodeModulesSize 484 MB 484 MB ⚠️ +2.09 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
/ failed reqs 0 0
/ total time (seconds) 4.696 4.489 -0.21
/ avg req/sec 532.4 556.91 +24.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.271 2.239 -0.03
/error-in-render avg req/sec 1100.78 1116.72 +15.94
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.68 kB 5.68 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.32 kB 2.32 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
buildDuration 23.5s 22.5s -943ms
buildDurationCached 7.5s 7.2s -268ms
nodeModulesSize 484 MB 484 MB ⚠️ +2.09 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
/ failed reqs 0 0
/ total time (seconds) 4.356 4.13 -0.23
/ avg req/sec 573.97 605.26 +31.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.058 2.028 -0.03
/error-in-render avg req/sec 1214.54 1232.57 +18.03
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.03 kB 3.03 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.38 kB 2.38 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-typescript-vaidator Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: dc1aeac

@Brooooooklyn
Copy link
Contributor Author

Merged in #36082

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-next-app --ts not recognising @types/react
2 participants