New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix symlink and copy logic to standalone
directory when using outputStandalone
#35535
Merged
timneutkens
merged 17 commits into
vercel:canary
from
remorses:fix-symlinks-with-standalone
Apr 15, 2022
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
aaf9c98
fix symlink logic with outputStandalone
remorses 119d9ff
refactored and commented copy function
remorses b3bc508
faster symlink check
remorses 22ac196
removed Dockerfile
remorses 06a6759
removed console.logs from test
remorses 7acfea0
fix symlinksOutsideRoot test
remorses 025c562
Merge remote-tracking branch 'upstream/canary' into fix-symlinks-with…
remorses 1de776a
removed a console.log for files out of root
remorses 8dfa95a
added missing types to copy
remorses c94a30c
Merge branch 'canary' into fix-symlinks-with-standalone
remorses 5e53eb0
Merge remote-tracking branch 'upstream/canary' into fix-symlinks-with…
remorses fdd1496
removed custom copy function, fix symlink code
remorses 992866c
test outputStandalone and pnpm
remorses c415f48
Merge remote-tracking branch 'upstream/canary' into fix-symlinks-with…
remorses c474595
appProcess is no more a promise
remorses b85c223
Merge branch 'canary' into fix-symlinks-with-standalone
remorses 51c6d59
Merge branch 'canary' into fix-symlinks-with-standalone
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# put modules outside of the app folder, to simulate what happens in a pnpm workspace | ||
virtual-store-dir=../pnpm |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
const path = require('path') | ||
|
||
module.exports = { | ||
experimental: { | ||
outputStandalone: true, | ||
// pnpm virtual-store-dir is outside the app directory | ||
outputFileTracingRoot: path.resolve(__dirname, '../'), | ||
}, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
module.exports = { | ||
experimental: { | ||
outputStandalone: true, | ||
}, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
symlink
is already a relative path, no need to usepath.relative