Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only warn styles and scripts under next head in concurrent mode #34897

Merged
merged 2 commits into from Feb 28, 2022
Merged

Only warn styles and scripts under next head in concurrent mode #34897

merged 2 commits into from Feb 28, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 28, 2022

x-ref: #34021 , #34004

Only log each warning once and only trigger in concurrent mode

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 28, 2022
@huozhi huozhi marked this pull request as ready for review February 28, 2022 21:47
ijjk
ijjk previously approved these changes Feb 28, 2022
View reviewed changes
@ijjk

This comment has been minimized.

Sign in to view
@huozhi huozhi requested a review from ijjk February 28, 2022 22:19
@ijjk
Copy link
Member

ijjk commented Feb 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js reduce-warning Change
buildDuration 20.7s 20.1s -660ms
buildDurationCached 7.9s 7.8s -105ms
nodeModulesSize 368 MB 368 MB ⚠️ +523 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js reduce-warning Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.249 4.336 ⚠️ +0.09
/ avg req/sec 588.34 576.55 ⚠️ -11.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.995 2.148 ⚠️ +0.15
/error-in-render avg req/sec 1253.07 1163.92 ⚠️ -89.15
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary huozhi/next.js reduce-warning Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.8 kB 27.9 kB ⚠️ +17 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.5 kB 71.5 kB ⚠️ +17 B
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js reduce-warning Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary huozhi/next.js reduce-warning Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ⚠️ +6 B
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ⚠️ +6 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary huozhi/next.js reduce-warning Change
_buildManifest.js gzip 460 B 459 B -1 B
Overall change 460 B 459 B -1 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary huozhi/next.js reduce-warning Change
index.html gzip 532 B 531 B -1 B
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB -1 B

Diffs

Diff for _buildManifest.js 
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-e46f7cf4e561503a.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-bbf9913b6d4f3129.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-bd830310f23f09be.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-b932c7479a7c37ca.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"
Diff for image-HASH.js 
@@ -132,6 +132,7 @@
       var _imageConfig = __webpack_require__(9309);
       var _useIntersection = __webpack_require__(7190);
       var _imageConfigContext = __webpack_require__(9977);
+      var _utils = __webpack_require__(3794);
       function _defineProperty1(obj, key, value) {
         if (key in obj) {
           Object.defineProperty(obj, key, {
@@ -239,10 +240,6 @@
         "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7";
       if (false) {
       }
-      var warnOnce = function(_) {};
-      if (false) {
-        var warnings;
-      }
       var VALID_LOADING_VALUES = /* unused pure expression or super */ null && [
         "lazy",
         "eager",
Diff for main-HASH.js 
@@ -3677,6 +3677,7 @@
       var _ampContext = __webpack_require__(2227);
       var _headManagerContext = __webpack_require__(8404);
       var _amp = __webpack_require__(3240);
+      var _utils = __webpack_require__(3794);
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
           ? obj
@@ -8054,7 +8055,7 @@
       exports.isResSent = isResSent;
       exports.normalizeRepeatedSlashes = normalizeRepeatedSlashes;
       exports.loadGetInitialProps = loadGetInitialProps;
-      exports.ST = exports.SP = void 0;
+      exports.ST = exports.SP = exports.warnOnce = void 0;
       function execOnce(fn) {
         var used = false;
         var result;
@@ -8189,6 +8190,11 @@
         );
         return _loadGetInitialProps.apply(this, arguments);
       }
+      var warnOnce = function(_) {};
+      if (false) {
+        var warnings;
+      }
+      exports.warnOnce = warnOnce;
       var SP = typeof performance !== "undefined";
       exports.SP = SP;
       var ST =
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-4566918fec87b11c.js"
+      src="/_next/static/chunks/main-f50e5c33a40c464c.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-4566918fec87b11c.js"
+      src="/_next/static/chunks/main-f50e5c33a40c464c.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-4566918fec87b11c.js"
+      src="/_next/static/chunks/main-f50e5c33a40c464c.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js reduce-warning Change
buildDuration 24.6s 24.7s ⚠️ +87ms
buildDurationCached 7.8s 7.7s -44ms
nodeModulesSize 368 MB 368 MB ⚠️ +523 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js reduce-warning Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.332 4.304 -0.03
/ avg req/sec 577.09 580.81 +3.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.171 2.057 -0.11
/error-in-render avg req/sec 1151.3 1215.32 +64.02
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary huozhi/next.js reduce-warning Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ⚠️ +17 B
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ⚠️ +17 B
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js reduce-warning Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages Overall increase ⚠️
vercel/next.js canary huozhi/next.js reduce-warning Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.08 kB 5.09 kB ⚠️ +6 B
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ⚠️ +6 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary huozhi/next.js reduce-warning Change
_buildManifest.js gzip 459 B 458 B -1 B
Overall change 459 B 458 B -1 B
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary huozhi/next.js reduce-warning Change
index.html gzip 534 B 532 B -2 B
link.html gzip 547 B 546 B -1 B
withRouter.html gzip 528 B 526 B -2 B
Overall change 1.61 kB 1.6 kB -5 B

Diffs

Diff for _buildManifest.js 
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-e46f7cf4e561503a.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-bbf9913b6d4f3129.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-bd830310f23f09be.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-b932c7479a7c37ca.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"
Diff for image-HASH.js 
@@ -132,6 +132,7 @@
       var _imageConfig = __webpack_require__(9309);
       var _useIntersection = __webpack_require__(7190);
       var _imageConfigContext = __webpack_require__(9977);
+      var _utils = __webpack_require__(3794);
       function _defineProperty1(obj, key, value) {
         if (key in obj) {
           Object.defineProperty(obj, key, {
@@ -239,10 +240,6 @@
         "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7";
       if (false) {
       }
-      var warnOnce = function(_) {};
-      if (false) {
-        var warnings;
-      }
       var VALID_LOADING_VALUES = /* unused pure expression or super */ null && [
         "lazy",
         "eager",
Diff for main-HASH.js 
@@ -3677,6 +3677,7 @@
       var _ampContext = __webpack_require__(2227);
       var _headManagerContext = __webpack_require__(8404);
       var _amp = __webpack_require__(3240);
+      var _utils = __webpack_require__(3794);
       function _interopRequireDefault(obj) {
         return obj && obj.__esModule
           ? obj
@@ -8054,7 +8055,7 @@
       exports.isResSent = isResSent;
       exports.normalizeRepeatedSlashes = normalizeRepeatedSlashes;
       exports.loadGetInitialProps = loadGetInitialProps;
-      exports.ST = exports.SP = void 0;
+      exports.ST = exports.SP = exports.warnOnce = void 0;
       function execOnce(fn) {
         var used = false;
         var result;
@@ -8189,6 +8190,11 @@
         );
         return _loadGetInitialProps.apply(this, arguments);
       }
+      var warnOnce = function(_) {};
+      if (false) {
+        var warnings;
+      }
+      exports.warnOnce = warnOnce;
       var SP = typeof performance !== "undefined";
       exports.SP = SP;
       var ST =
Diff for index.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-4566918fec87b11c.js"
+      src="/_next/static/chunks/main-f50e5c33a40c464c.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-4566918fec87b11c.js"
+      src="/_next/static/chunks/main-f50e5c33a40c464c.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-4566918fec87b11c.js"
+      src="/_next/static/chunks/main-f50e5c33a40c464c.js"
       defer=""
     ></script>
     <script
Commit: f5e56c7

@kodiakhq kodiakhq bot merged commit 57702cb into vercel:canary Feb 28, 2022
@shuding shuding deleted the reduce-warning branch March 1, 2022 12:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huozhi @ijjk