Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React 18 overview.md #34657

Closed
wants to merge 1 commit into from

Conversation

AndrewVetovitz
Copy link

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@huozhi
Copy link
Member

huozhi commented Feb 21, 2022

If you're using react rc this step is not required cause nextjs is detecting react 18 and try to enable it for you. Did you have encountered problem with the latest canary?

@AndrewVetovitz AndrewVetovitz changed the title Update overview.md Update React 18 overview.md Feb 21, 2022
@AndrewVetovitz
Copy link
Author

AndrewVetovitz commented Feb 21, 2022

@huozhi next 12.1 - I did not use the canary. React 18 works with 12.1, for those not using the canary this is something worth adding to the docs because it does not work without this field. If this is not intended then 12.1 is not properly finding react 18, otherwise, I think the docs should mention this outright.

@huozhi
Copy link
Member

huozhi commented Feb 21, 2022

@AndrewVetovitz Yeah there was a bug #34500 that reactRoot is not properly enabled in 12.1.0 and fixed in the canary. Can you check if you're seeing the same error?

We still want to keep the doc simple to make configuration less and simple. You can definitely keet it as a workaround in your app or try nextjs canary. And once the patch is out you can still have the react 18 auto-detection with it. If it's some error else I can take a quick look

@AndrewVetovitz
Copy link
Author

I don't plan on checking out canary. I'll close this then since it will be fixed on the next minor release and just keep what I have.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants