Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure workers are not left open #34503

Merged
merged 3 commits into from Feb 18, 2022
Merged

Ensure workers are not left open #34503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff5f265
ensure workers are closed
kinetifex Feb 17, 2022
b071370
Merge branch 'canary' into fix-hanging-workers
kodiakhq[bot] Feb 18, 2022
6f72ed6
Merge branch 'canary' into fix-hanging-workers
kodiakhq[bot] Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/next/build/index.ts
View file
Open in desktop
Expand Up @@ -1910,6 +1910,9 @@ export default async function build(
})
}

// ensure the worker is not left hanging
staticWorkers.close()

const analysisEnd = process.hrtime(analysisBegin)
telemetry.record(
eventBuildOptimize(pagePaths, {
Expand Down
9 changes: 9 additions & 0 deletions packages/next/lib/worker.ts
View file
Open in desktop
Expand Up @@ -85,4 +85,13 @@ export class Worker {
this._worker = undefined
return worker.end()
}

/**
* Quietly end the worker if it exists
*/
close(): void {
if (this._worker) {
this._worker.end()
}
}
}