Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reading request bodies in middlewares #34490

Closed
wants to merge 1 commit into from
Closed

Allow reading request bodies in middlewares #34490

wants to merge 1 commit into from

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 17, 2022

This re-lands #34294 now that v12.1 is up

Reverts #34479

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 17, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 17, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
buildDuration 15.7s 16.2s ⚠️ +466ms
buildDurationCached 6.1s 6.1s ⚠️ +32ms
nodeModulesSize 359 MB 359 MB ⚠️ +6.07 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.218 3.187 -0.03
/ avg req/sec 776.85 784.35 +7.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.363 1.351 -0.01
/error-in-render avg req/sec 1834.18 1851.03 +16.85
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
buildDuration 19.2s 19.2s -20ms
buildDurationCached 6.2s 6.1s -97ms
nodeModulesSize 359 MB 359 MB ⚠️ +6.07 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.228 3.235 ⚠️ +0.01
/ avg req/sec 774.36 772.79 ⚠️ -1.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.373 1.376 0
/error-in-render avg req/sec 1821.33 1817 ⚠️ -4.33
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.7 kB 71.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.08 kB 5.08 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-34479-revert-34294-read-json-body Change
index.html gzip 533 B 533 B ✓
link.html gzip 548 B 548 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: afc2ee2

@ijjk ijjk marked this pull request as ready for review February 17, 2022 19:56
@ijjk ijjk mentioned this pull request Feb 18, 2022
Merged
@kodiakhq kodiakhq bot closed this in #34519 Feb 18, 2022
kodiakhq bot pushed a commit that referenced this pull request Feb 18, 2022
@javivelasco @Schniz
Allow reading request bodies in middlewares (#34294) (#34519)
8752464 
This PR brings back @Schniz awesome contribution to bring in bodies to middleware. It was reverted to leave it out of the stable release and to have some time to test it out in canary before officially releasing it. This PR is simply a `cherry-pick` of his original work.

Closes: #30953 
Closes: #34490

Co-authored-by: Gal Schlezinger <2054772+Schniz@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk