Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(escapeStringRegexp): test before replace #34472

Merged
merged 2 commits into from Apr 16, 2022
Merged

perf(escapeStringRegexp): test before replace #34472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6978bc0
perf(escapeStringRegexp): test before replace (from lodash)
SukkaW Feb 17, 2022
eb987b8
Merge branch 'canary' into perf-escape-regex
ijjk Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/next/shared/lib/escape-regexp.ts
View file
Open in desktop
@@ -1,4 +1,11 @@
// regexp from https://github.com/sindresorhus/escape-string-regexp
// regexp is based on https://github.com/sindresorhus/escape-string-regexp
const reHasRegExp = /[|\\{}()[\]^$+*?.-]/
const reReplaceRegExp = /[|\\{}()[\]^$+*?.-]/g

export function escapeStringRegexp(str: string) {
return str.replace(/[|\\{}()[\]^$+*?.-]/g, '\\$&')
// see also: https://github.com/lodash/lodash/blob/2da024c3b4f9947a48517639de7560457cd4ec6c/escapeRegExp.js#L23
if (reHasRegExp.test(str)) {
return str.replace(reReplaceRegExp, '\\$&')
}
return str
}