Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for next/link next/image with "type": "module" #34414

Closed
wants to merge 1 commit into from

Conversation

timneutkens
Copy link
Member

  • Failing test
  • Add "exports" to Next.js package.json

Fixes #34412

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Feb 16, 2022
@ijjk
Copy link
Member

ijjk commented Feb 16, 2022

Failing test suites

Commit: f13296d

yarn testheadless test/e2e/type-module-interop/index.test.ts

  • Type module interop > should render server-side with modules
  • Type module interop > should render client-side with modules
Expand output

● Type module interop › should render server-side with modules

expect(received).toBe(expected) // Object.is equality

Expected: "link to home"
Received: ""

  54 |     const html = await renderViaHTTP(next.url, '/modules')
  55 |     const $ = cheerio.load(html)
> 56 |     expect($('#link-to-home').text()).toBe('link to home')
     |                                       ^
  57 |   })
  58 |
  59 |   it('should render client-side with modules', async () => {

  at Object.<anonymous> (e2e/type-module-interop/index.test.ts:56:39)

● Type module interop › should render client-side with modules

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  59 |   it('should render client-side with modules', async () => {
  60 |     const browser = await webdriver(next.url, '/modules')
> 61 |     expect(await hasRedbox(browser)).toBe(false)
     |                                      ^
  62 |     await browser.close()
  63 |   })
  64 | })

  at Object.<anonymous> (e2e/type-module-interop/index.test.ts:61:38)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary timneutkens/next.js fix/34412 Change
buildDuration 18.9s 18.9s ⚠️ +2ms
buildDurationCached 7.2s 7.4s ⚠️ +128ms
nodeModulesSize 367 MB 367 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/34412 Change
/ failed reqs 0 0
/ total time (seconds) 3.844 3.822 -0.02
/ avg req/sec 650.36 654.17 +3.81
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.664 1.684 ⚠️ +0.02
/error-in-render avg req/sec 1502.44 1484.12 ⚠️ -18.32
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/34412 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/34412 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/34412 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/34412 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/34412 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary timneutkens/next.js fix/34412 Change
buildDuration 22.3s 22.6s ⚠️ +307ms
buildDurationCached 7.3s 7.2s -113ms
nodeModulesSize 367 MB 367 MB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/34412 Change
/ failed reqs 0 0
/ total time (seconds) 3.804 3.858 ⚠️ +0.05
/ avg req/sec 657.22 647.95 ⚠️ -9.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.74 1.715 -0.02
/error-in-render avg req/sec 1436.83 1457.74 +20.91
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/34412 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/34412 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/34412 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/34412 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/34412 Change
index.html gzip 533 B 533 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: f13296d

@Brooooooklyn
Copy link
Contributor

Continue on #35933

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using "type": "module" import does not interop the default export for commonjs modules
3 participants