Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to leverage response-cache for image-optimizer #34075

Merged
merged 20 commits into from Feb 8, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 7, 2022

Co-authored-by: Steven <steven@ceriously.com>
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 7, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

styfle
styfle previously approved these changes Feb 8, 2022
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks! 🥇

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review February 8, 2022 17:17
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Feb 8, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
buildDuration 19.7s 19.8s ⚠️ +131ms
buildDurationCached 7.8s 7.6s -221ms
nodeModulesSize 359 MB 359 MB ⚠️ +8.4 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
/ failed reqs 0 0
/ total time (seconds) 4.325 4.328 0
/ avg req/sec 578.09 577.65 ⚠️ -0.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.122 2.18 ⚠️ +0.06
/error-in-render avg req/sec 1178.21 1146.65 ⚠️ -31.56
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
buildDuration 24.4s 24.9s ⚠️ +407ms
buildDurationCached 7.6s 7.6s -30ms
nodeModulesSize 359 MB 359 MB ⚠️ +8.4 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
/ failed reqs 0 0
/ total time (seconds) 4.269 4.4 ⚠️ +0.13
/ avg req/sec 585.67 568.2 ⚠️ -17.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.168 2.114 -0.05
/error-in-render avg req/sec 1153.28 1182.65 +29.37
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/leverage-response-cache Change
index.html gzip 533 B 533 B
link.html gzip 548 B 548 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: a75a538

@styfle styfle merged commit 130f864 into vercel:canary Feb 8, 2022
@ijjk ijjk deleted the update/leverage-response-cache branch February 8, 2022 23:47
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
This updates to leverage our `response-cache` used for ISR for our `image-optimizer` as well. 

Co-authored-by: Steven <steven@ceriously.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants