Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to delete URL search params in middleware rewrites #33725

Merged
merged 8 commits into from Jan 27, 2022
Merged

Allow to delete URL search params in middleware rewrites #33725

merged 8 commits into from Jan 27, 2022

Commits on Jan 27, 2022

  1. Don't merge queryparams in middleware rewrites 

    This allows to have a more streamlined API for rewrites.
Since middlewares are code and not static configurations, we can allow people to
delete query params and not just overwrite them.
    @Schniz
    Schniz committed Jan 27, 2022
    Copy the full SHA
    6269320 View commit details
    Browse the repository at this point in the history

  2. add a test case

    @Schniz
    Schniz committed Jan 27, 2022
    Copy the full SHA
    29bc67b View commit details
    Browse the repository at this point in the history

  3. Update packages/next/server/next-server.ts 

    Co-authored-by: JJ Kasper <jj@jjsweb.site>
    @Schniz @ijjk
    Schniz and ijjk committed Jan 27, 2022
    Copy the full SHA
    ce31465 View commit details
    Browse the repository at this point in the history

  4. Update packages/next/server/next-server.ts 

    Co-authored-by: JJ Kasper <jj@jjsweb.site>
    @Schniz @ijjk
    Schniz and ijjk committed Jan 27, 2022
    Copy the full SHA
    0ec02c9 View commit details
    Browse the repository at this point in the history

  5. warn once, and test that it actually warns

    @Schniz
    Schniz committed Jan 27, 2022
    Copy the full SHA
    1615cc3 View commit details
    Browse the repository at this point in the history

  6. fix lint

    @Schniz
    Schniz committed Jan 27, 2022
    Copy the full SHA
    608d3b5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'canary' into dont-merge-qp-in-rewrites

    @kodiakhq
    kodiakhq[bot] committed Jan 27, 2022
    Copy the full SHA
    5a92d5e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'canary' into dont-merge-qp-in-rewrites

    @ijjk
    ijjk committed Jan 27, 2022
    Copy the full SHA
    6ee5b2f View commit details
    Browse the repository at this point in the history