Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-docker example dockerfile #33695

Merged
merged 6 commits into from Jan 27, 2022
Merged

Fix with-docker example dockerfile #33695

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1fcf6d3
Fix `with-docker` example dockerfile
krystxf Jan 26, 2022
ffe5d13
don't fail when file is doesn't exist
krystxf Jan 26, 2022
803fdcf
Update examples/with-docker/Dockerfile
krystxf Jan 26, 2022
ce1fca4
Merge branch 'canary' into fix/with-docker-example
krystxf Jan 26, 2022
9b6c693
Apply suggestions from code review
ijjk Jan 27, 2022
9c4b72f
Merge branch 'canary' into fix/with-docker-example
kodiakhq[bot] Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/with-docker/Dockerfile
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@ FROM node:16-alpine AS deps
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
RUN apk add --no-cache libc6-compat
WORKDIR /app
COPY package.json yarn.lock ./
COPY package.json yarn.lock* package-lock.json* ./
RUN yarn install --frozen-lockfile
krystxf marked this conversation as resolved.
Show resolved Hide resolved

# Rebuild the source code only when needed
Expand Down