Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize offline condition judgment #33238

Merged
merged 15 commits into from Feb 2, 2022
+12 −21
Merged

Optimize offline condition judgment #33238

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ca36161
perf: optimize offline condition judgment
zh-lx Jan 13, 2022
9c92746
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 13, 2022
b44a964
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 14, 2022
fc39a20
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 17, 2022
6d62e98
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 23, 2022
cd72871
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 27, 2022
8e93e28
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 28, 2022
fdf1a32
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 28, 2022
bda31c4
Merge branch 'canary' into perf-offline-judgment
zh-lx Jan 29, 2022
40fc1e6
Merge branch 'canary' into perf-offline-judgment
kodiakhq[bot] Jan 31, 2022
a7fd149
Merge branch 'canary' into perf-offline-judgment
zh-lx Feb 2, 2022
559dc98
Merge branch 'canary' into perf-offline-judgment
kodiakhq[bot] Feb 2, 2022
a6f550e
Merge branch 'canary' into perf-offline-judgment
zh-lx Feb 2, 2022
ce9a7c5
Merge branch 'canary' into perf-offline-judgment
ijjk Feb 2, 2022
e1088c4
lint-fix
ijjk Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 4 additions & 7 deletions packages/create-next-app/helpers/install.ts
View file
Open in desktop
Expand Up @@ -69,16 +69,13 @@ export function install(
* install`.
*/
args = ['install']
if (useYarn) {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
if(!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
if (useYarn) {
console.log(chalk.yellow('Falling back to the local Yarn cache.'))
console.log()
args.push('--offline')
}
} else {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
} else {
console.log()
}
}
Expand Down
11 changes: 4 additions & 7 deletions packages/next-codemod/lib/install.ts
View file
Open in desktop
Expand Up @@ -69,16 +69,13 @@ export function install(
* install`.
*/
args = ['install']
if (useYarn) {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
if(!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
if (useYarn) {
console.log(chalk.yellow('Falling back to the local Yarn cache.'))
console.log()
args.push('--offline')
}
} else {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
} else {
console.log()
}
}
Expand Down
11 changes: 4 additions & 7 deletions packages/next/lib/helpers/install.ts
View file
Open in desktop
Expand Up @@ -69,16 +69,13 @@ export function install(
* install`.
*/
args = ['install']
if (useYarn) {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
if(!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
if (useYarn) {
console.log(chalk.yellow('Falling back to the local Yarn cache.'))
console.log()
args.push('--offline')
}
} else {
if (!isOnline) {
console.log(chalk.yellow('You appear to be offline.'))
} else {
console.log()
}
}
Expand Down