New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed data fetching file name to overview to fix meta data title #33232
Conversation
Co-authored-by: Steven <steven@ceriously.com>
@styfle would you mind taking another look here please, and merging if all 🟢 |
It looks like the manifest needs to be updated still https://github.com/vercel/next.js/runs/4896213283?check_suite_focus=true |
Thanks @ijjk I confused how this works. This is the snippet:
Do i change the original path to point to |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
buildDuration | 12.7s | 12.6s | -65ms |
buildDurationCached | 3.2s | 3.2s | -32ms |
nodeModulesSize | 356 MB | 356 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.945 | 2.929 | -0.02 |
/ avg req/sec | 848.94 | 853.62 | +4.68 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.399 | 1.376 | -0.02 |
/error-in-render avg req/sec | 1787.39 | 1816.75 | +29.36 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 27.2 kB | 27.2 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71 kB | 71 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 919 B | 919 B | ✓ |
image-HASH.js gzip | 4.94 kB | 4.94 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.4 kB | 14.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
_buildManifest.js gzip | 460 B | 460 B | ✓ |
Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
buildDuration | 16s | 16.4s | |
buildDurationCached | 3.3s | 3.2s | -83ms |
nodeModulesSize | 356 MB | 356 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.906 | 2.914 | |
/ avg req/sec | 860.25 | 857.93 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.392 | 1.398 | |
/error-in-render avg req/sec | 1795.42 | 1788.82 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 27.3 kB | 27.3 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71.3 kB | 71.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 911 B | 911 B | ✓ |
image-HASH.js gzip | 4.97 kB | 4.97 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.21 kB | 2.21 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.3 kB | 14.3 kB | ✓ |
Client Build Manifests
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | molebox/next.js fix-data-fetching-meta-data | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
…ercel#33232) * Changed data fetching file name to overview to fix meta data title * Update docs/api-reference/data-fetching/get-server-side-props.md Co-authored-by: Steven <steven@ceriously.com> * Update manifest and check Co-authored-by: Steven <steven@ceriously.com> Co-authored-by: JJ Kasper <jj@jjsweb.site>
This PR aims to fix the meta data title on og images by changing the file path name from index to overview. It also fixes all links to this path and adds a redirect on the route
fixes #33522
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint