Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix global process testing for the process polyfill #33220

Merged
merged 6 commits into from Jan 13, 2022
Merged

Fix global process testing for the process polyfill #33220

merged 6 commits into from Jan 13, 2022

Commits on Jan 12, 2022

  1. Fix global process testing for the process polyfill 

    When there is a DOM element with id of `process`, the DOM marks it as a
global, so `window.process` would exist. We should check for
`process.env` to make sure it is available too.
    @Schniz
    Schniz committed Jan 12, 2022
    Copy the full SHA
    81a3395 View commit details
    Browse the repository at this point in the history

  2. Ensure a failing test

    @Schniz
    Schniz committed Jan 12, 2022
    Copy the full SHA
    4822dda View commit details
    Browse the repository at this point in the history

  3. Fix page count

    @Schniz
    Schniz committed Jan 12, 2022
    Copy the full SHA
    17bf828 View commit details
    Browse the repository at this point in the history

  4. Fix the underlying bug 

    but I can't make the test fail on this repo. However, it does happen
when I create a new repo with the same code.
    @Schniz
    Schniz committed Jan 12, 2022
    Copy the full SHA
    e1a8107 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Check that process.env is not null 

    Co-authored-by: JJ Kasper <jj@jjsweb.site>
    @Schniz @ijjk
    Schniz and ijjk committed Jan 13, 2022
    Copy the full SHA
    ecb2b68 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'canary' into fix-global-process-testing

    @kodiakhq
    kodiakhq[bot] committed Jan 13, 2022
    Copy the full SHA
    0956aa7 View commit details
    Browse the repository at this point in the history