Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a typo #33108

Closed
wants to merge 1 commit into from
Closed

Fixes a typo #33108

wants to merge 1 commit into from

Conversation

JaimeObregon
Copy link

Fixes a typo which might lead to accidentally commit the local secrets file.

Fixes a typo which might lead to accidentally commit the local secrets file.
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current docs look correct, what is the behavior you're seeing?

@JaimeObregon
Copy link
Author

Thank you for reviewing this, @timneutkens. I am new to Next.js and was just reading the docs when I realized .env.local wouldn't be .gitignore'd by .env.*.local. Am I wrong?

@balazsorban44
Copy link
Member

balazsorban44 commented Jan 11, 2022

Looks correct what @JaimeObregon is suggesting. The .*. pattern would not match .env.local since it only has a single . in the middle.

@balazsorban44
Copy link
Member

balazsorban44 commented Jan 11, 2022

This is actually a duplicate of #32647 I suggest @JaimeObregon you follow that, and if the author does not respond to the review, we can go ahead with this PR. Otherwise, I kindly ask you to close it, since they opened the PR first.

@balazsorban44
Copy link
Member

The other PR has been merged, so I am closing this. Thanks anyway! 🙏

@vercel vercel locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants