New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate process.browser #32862
Merged
kodiakhq
merged 5 commits into
vercel:canary
from
PepijnSenders:feature/deprecate-process-browser
Jan 27, 2022
Merged
chore: deprecate process.browser #32862
kodiakhq
merged 5 commits into
vercel:canary
from
PepijnSenders:feature/deprecate-process-browser
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PepijnSenders
requested review from
huozhi,
ijjk,
shuding and
timneutkens
as code owners
December 27, 2021 22:49
PepijnSenders
force-pushed
the
feature/deprecate-process-browser
branch
from
December 27, 2021 22:50
119862e
to
204195a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
timneutkens
approved these changes
Jan 27, 2022
Thanks 👍 |
This comment has been minimized.
This comment has been minimized.
ijjk
approved these changes
Jan 27, 2022
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
buildDuration | 11.9s | 11.5s | -374ms |
buildDurationCached | 3.2s | 3.3s | |
nodeModulesSize | 358 MB | 358 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.879 | 2.677 | -0.2 |
/ avg req/sec | 868.23 | 933.88 | +65.65 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.372 | 1.285 | -0.09 |
/error-in-render avg req/sec | 1822.27 | 1945.15 | +122.88 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 27.2 kB | 27.2 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71 kB | 71 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 919 B | 919 B | ✓ |
image-HASH.js gzip | 4.94 kB | 4.94 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.4 kB | 14.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
_buildManifest.js gzip | 460 B | 460 B | ✓ |
Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
buildDuration | 14.6s | 14.5s | -169ms |
buildDurationCached | 3.1s | 3.1s | -66ms |
nodeModulesSize | 358 MB | 358 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.695 | 2.698 | 0 |
/ avg req/sec | 927.71 | 926.68 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.318 | 1.279 | -0.04 |
/error-in-render avg req/sec | 1896.89 | 1954.85 | +57.96 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 27.3 kB | 27.3 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71.3 kB | 71.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 911 B | 911 B | ✓ |
image-HASH.js gzip | 4.97 kB | 4.97 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.21 kB | 2.21 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.3 kB | 14.3 kB | ✓ |
Client Build Manifests
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | PepijnSenders/next.js feature/deprecate-process-browser | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Where
I've answered it one year ago here: #7651 (comment) |
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This value has been deprecated in favor of `typeof window !== 'undefined'` a long time ago ([ref](vercel#7651)). We should also deprecate the value in the global types as it might give the wrong assumption that this value should still be used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value has been deprecated in favor of
typeof window !== 'undefined'
a long time ago (ref). We should also deprecate the value in the global types as it might give the wrong assumption that this value should still be used.