Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure setImmediate and punycode are polyfilled #32768

Merged
merged 4 commits into from Jan 3, 2022
Merged

Ensure setImmediate and punycode are polyfilled #32768

merged 4 commits into from Jan 3, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 23, 2021

Follow-up to #32627 it seems some users were relying on setimmediate being hoisted from timers-browserify so this ensures that is aliased and also ensures punycode is properly available as well. This also moves the node browser polyfills tests to an isolated suite to ensure no missing modules.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 23, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review December 23, 2021 16:50
@ijjk ijjk requested a review from styfle January 3, 2022 16:15
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jan 3, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
buildDuration 13.8s 14.2s ⚠️ +370ms
buildDurationCached 3.2s 3.2s -28ms
nodeModulesSize 348 MB 348 MB ⚠️ +3.97 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.831 2.851 ⚠️ +0.02
/ avg req/sec 883.17 877.02 ⚠️ -6.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.33 1.276 -0.05
/error-in-render avg req/sec 1879.75 1959.5 +79.75
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
buildDuration 15.4s 15.3s -91ms
buildDurationCached 3.2s 3.1s -10ms
nodeModulesSize 348 MB 348 MB ⚠️ +3.97 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.837 2.831 -0.01
/ avg req/sec 881.12 883.13 +2.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.286 1.277 -0.01
/error-in-render avg req/sec 1944.28 1958.39 +14.11
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/node-browser-polyfills Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 4c77318

@ijjk ijjk merged commit 52cf7fe into vercel:canary Jan 3, 2022
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 5, 2022
@teleaziz
Merge branch 'canary' of github.com:vercel/next.js into cms-builder-i…
c9fadc8 
…o-example

* 'canary' of github.com:vercel/next.js:
  [chore] Update `deta` version in examples (vercel#30204)
  fix: typescript example supporting strict w/ version >= 4.4 (vercel#33042)
  Avoid page double render with emotion vanilla (vercel#30541)
  converted the old tailwind css example to typescript  (vercel#32808)
  fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html (vercel#30321)
  Ensure NODE_ENV is not inlined for next/jest (vercel#33032)
  Rename api in with-redis example (vercel#33016)
  Remove unused turbo remote cache env vars (vercel#33030)
  v12.0.8-canary.17
  Re-enable turbo caching for swc build jobs (vercel#32617)
  feat(cli): introduce `next info` CLI command (vercel#32972)
  fix(examples): add missing dependencies wo (vercel#32977)
  Updated wrong link to example of gtag init in measuring-performance.md (vercel#32974)
  v12.0.8-canary.16
  Revert "Reduce install size for linux glibc/musl (vercel#32850)" (vercel#32973)
  Ensure middleware is output in standalone mode (vercel#32967)
  v12.0.8-canary.15
  Reduce install size for linux glibc/musl (vercel#32850)
  Fixes issue with makeStylesheetInert (vercel#32027)
  Ensure setImmediate and punycode are polyfilled (vercel#32768)
@vercel vercel locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle