Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add timeout for dev entries to avoid hard navigation #32476

Merged
merged 1 commit into from Dec 14, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 13, 2021

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Dec 13, 2021
@huozhi huozhi changed the title test: add timeout for dev entries to avoid hard link test: add timeout for dev entries to avoid hard navigation Dec 13, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 14, 2021

Failing test suites

Commit: 2ea37d4

test/integration/react-streaming-and-server-components/test/index.test.js

  • concurrentFeatures - dev > should support next/link
Expand output

● concurrentFeatures - dev › should support next/link

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: undefined

  259 |     )
  260 |     const dynamicRouteHTML2 = await renderViaHTTP(
> 261 |       context.appPort,
      |                       ^
  262 |       '/routes/dynamic2'
  263 |     )
  264 |

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:261:56)

@huozhi huozhi force-pushed the test/ondemand-entries-timeout branch from 2ea37d4 to cae8c04 Compare December 14, 2021 09:15
@ijjk
Copy link
Member

ijjk commented Dec 14, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
buildDuration 21.5s 21.9s ⚠️ +459ms
buildDurationCached 4.1s 3.9s -136ms
nodeModulesSize 350 MB 350 MB -1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
/ failed reqs 0 0
/ total time (seconds) 3.392 3.54 ⚠️ +0.15
/ avg req/sec 736.97 706.16 ⚠️ -30.81
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.532 1.592 ⚠️ +0.06
/error-in-render avg req/sec 1631.85 1570.73 ⚠️ -61.12
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 30.2 kB 30.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
buildDuration 22.4s 22.8s ⚠️ +435ms
buildDurationCached 3.9s 3.8s -83ms
nodeModulesSize 350 MB 350 MB -1 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
/ failed reqs 0 0
/ total time (seconds) 3.633 3.455 -0.18
/ avg req/sec 688.08 723.58 +35.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.621 1.599 -0.02
/error-in-render avg req/sec 1542.44 1563.78 +21.34
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 30.3 kB 30.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 74.2 kB 74.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/ondemand-entries-timeout Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: cae8c04

@timneutkens timneutkens merged commit cbe1844 into vercel:canary Dec 14, 2021
cdierkens pushed a commit to cdierkens/next.js that referenced this pull request Dec 20, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the test/ondemand-entries-timeout branch February 3, 2022 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants