Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for inline embedding data in the web runtime #32471

Merged
merged 5 commits into from Dec 13, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 11 additions & 19 deletions packages/next/server/render.tsx
Expand Up @@ -62,6 +62,7 @@ import {
import { DomainLocale } from './config'
import RenderResult, { NodeWritablePiper } from './render-result'
import isError from '../lib/is-error'
import { readableStreamTee } from './web/utils'

let Writable: typeof import('stream').Writable
let Buffer: typeof import('buffer').Buffer
Expand Down Expand Up @@ -293,37 +294,28 @@ function createRSCHook() {
) => {
let entry = rscCache.get(id)
if (!entry) {
const [renderStream, forwardStream] = req.tee()
const [renderStream, forwardStream] = readableStreamTee(req)
entry = createFromReadableStream(renderStream)
rscCache.set(id, entry)

const transfomer = new TransformStream({
start(controller) {
if (bootstrap) {
controller.enqueue(
ReactDOMServer.renderToString(
<script
dangerouslySetInnerHTML={{
__html: `(self.__next_s=self.__next_s||[]).push(${JSON.stringify(
[0, id]
)})`,
}}
/>
)
`<script>(self.__next_s=self.__next_s||[]).push(${JSON.stringify([
0,
id,
])})</script>`
)
}
},
transform(chunk, controller) {
controller.enqueue(
ReactDOMServer.renderToString(
<script
dangerouslySetInnerHTML={{
__html: `(self.__next_s=self.__next_s||[]).push(${JSON.stringify(
[1, id, decoder.decode(chunk)]
)})`,
}}
/>
)
`<script>(self.__next_s=self.__next_s||[]).push(${JSON.stringify([
1,
id,
decoder.decode(chunk),
])})</script>`
)
},
})
Expand Down
26 changes: 26 additions & 0 deletions packages/next/server/web/utils.ts
Expand Up @@ -14,6 +14,32 @@ export async function* streamToIterator<T>(
reader.releaseLock()
}

export function readableStreamTee<T = any>(
readable: ReadableStream<T>
): [ReadableStream<T>, ReadableStream<T>] {
const transformStream = new TransformStream()
const transformStream2 = new TransformStream()
const writer = transformStream.writable.getWriter()
const writer2 = transformStream2.writable.getWriter()

const reader = readable.getReader()
function read() {
reader.read().then(({ done, value }) => {
if (done) {
writer.close()
writer2.close()
return
}
writer.write(value)
writer2.write(value)
read()
})
}
read()

return [transformStream.readable, transformStream2.readable]
}

export function notImplemented(name: string, method: string): any {
throw new Error(
`Failed to get the '${method}' property on '${name}': the property is not implemented`
Expand Down