Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't choke on frameworks that don't exist #32324

Closed
wants to merge 1 commit into from

Conversation

JonathanWolfe
Copy link

@JonathanWolfe JonathanWolfe commented Dec 9, 2021

Fixes #31551

@ijjk ijjk added the type: next label Dec 9, 2021
@JonathanWolfe JonathanWolfe changed the title Don't choke on frameworks that don't exist - Fixes #31551 Don't choke on frameworks that don't exist Dec 9, 2021
@Izook
Copy link

Izook commented Jan 11, 2022

@JonathanWolfe Is there a reason why work on this PR was stopped? Was the try-catch not an effective solution?

@JonathanWolfe
Copy link
Author

@Izook No it works perfectly. The CICD fails for irrelevant reasons. I rebased a few times waiting for this to get fixed upstream by the nextjs team, but I've been on vacation so I didn't keep doing it.

@ijjk
Copy link
Member

ijjk commented Jan 13, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
buildDuration 13.2s 14.1s ⚠️ +858ms
buildDurationCached 3.5s 3.4s -121ms
nodeModulesSize 355 MB 355 MB ⚠️ +285 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.635 2.737 ⚠️ +0.1
/ avg req/sec 948.71 913.35 ⚠️ -35.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.232 1.31 ⚠️ +0.08
/error-in-render avg req/sec 2029.56 1908.95 ⚠️ -120.61
Client Bundles (main, webpack, commons)
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
buildDuration 13.6s 14.3s ⚠️ +691ms
buildDurationCached 3s 2.8s -207ms
nodeModulesSize 355 MB 355 MB ⚠️ +285 B
Page Load Tests Overall increase ✓
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.644 2.55 -0.09
/ avg req/sec 945.49 980.28 +34.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.316 1.171 -0.15
/error-in-render avg req/sec 1899.84 2135.43 +235.59
Client Bundles (main, webpack, commons)
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.72 kB 4.72 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14 kB 14 kB
Client Build Manifests
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary JonathanWolfe/next.js patch-1 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 6885277

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also make the change next week if you don't have time

@@ -720,7 +724,7 @@ export default async function getBaseWebpackConfig(
'use-subscription',
require.resolve('next', { paths: [dir] })
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to not hardcode react dependencies like scheduler and object-assign, but instead only call getPackagePath for react and follow all dependencies listed in the package.json of e. g. react and add them.

@kodiakhq kodiakhq bot closed this in #31264 Feb 6, 2022
kodiakhq bot pushed a commit that referenced this pull request Feb 6, 2022
…onfig (#31264)

Fixes: #31240
Closes: #32324
Adding a try-catch block to handle situations when packages are found at relative path in getPackagePath function. This is likely to occur when using `preact` instead of `react-dom`, as `scheduler` package will not be found wrt `react-dom`

## Bug

- [x] Related issues linked using `fixes #31240`

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
…pack-config (vercel#31264)

Fixes: vercel#31240
Closes: vercel#32324
Adding a try-catch block to handle situations when packages are found at relative path in getPackagePath function. This is likely to occur when using `preact` instead of `react-dom`, as `scheduler` package will not be found wrt `react-dom`

## Bug

- [x] Related issues linked using `fixes vercel#31240`

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad pnpm fix makes using preact impossible
4 participants