Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running server with Polyfilled fetch #32039

Closed
wants to merge 5 commits into from
Closed

Fix running server with Polyfilled fetch #32039

wants to merge 5 commits into from

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 2, 2021

This is an exact copy of #31935 to test the CI

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 2, 2021
@sokra sokra changed the title https://github.com/vercel/next.js/pull/31935 Fix running server with Polyfilled fetch Dec 2, 2021
@ijjk
Copy link
Member

ijjk commented Dec 2, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js javi-fix-30398 Change
buildDuration 18.6s 18.9s ⚠️ +298ms
buildDurationCached 3.5s 3.4s -48ms
nodeModulesSize 347 MB 347 MB ⚠️ +4.15 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js javi-fix-30398 Change
/ failed reqs 0 0
/ total time (seconds) 3.01 3.038 ⚠️ +0.03
/ avg req/sec 830.64 822.89 ⚠️ -7.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.39 1.385 0
/error-in-render avg req/sec 1799.03 1805.64 +6.61
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js javi-fix-30398 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js javi-fix-30398 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js javi-fix-30398 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js javi-fix-30398 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js javi-fix-30398 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js javi-fix-30398 Change
buildDuration 20.2s 20.3s ⚠️ +115ms
buildDurationCached 3.4s 3.5s ⚠️ +73ms
nodeModulesSize 347 MB 347 MB ⚠️ +4.15 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js javi-fix-30398 Change
/ failed reqs 0 0
/ total time (seconds) 3.057 2.967 -0.09
/ avg req/sec 817.88 842.55 +24.67
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.439 1.369 -0.07
/error-in-render avg req/sec 1737.22 1825.89 +88.67
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js javi-fix-30398 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js javi-fix-30398 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js javi-fix-30398 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js javi-fix-30398 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js javi-fix-30398 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: dca207f

@ijjk
Copy link
Member

ijjk commented Dec 2, 2021

Failing test suites

Commit: dca207f

test/integration/image-component/base-path/test/static.test.js

  • Static Image Component Tests for basePath > dev mode > Should allow an image with a static src to omit height and width
  • Static Image Component Tests for basePath > dev mode > Should use immutable cache-control header for static import
  • Static Image Component Tests for basePath > dev mode > Should automatically provide an image height and width
  • Static Image Component Tests for basePath > dev mode > Should allow provided width and height to override intrinsic
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported jpg
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported png
Expand output

● Static Image Component Tests for basePath › dev mode › Should allow an image with a static src to omit height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:33033/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should use immutable cache-control header for static import

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:33033/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should automatically provide an image height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:33033/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should allow provided width and height to override intrinsic

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:33033/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported jpg

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:33033/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported png

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:33033/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

@sokra sokra closed this Dec 2, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@sokra sokra deleted the javi-fix-30398 branch April 4, 2023 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants