JSON.stringify generic errors #31866

mozeryansky · 2021-11-27T09:03:13Z

Use JSON.stringify instead of creating a string from an unknown error using error + ''.

timneutkens

Can you add a test for this change?

mozeryansky · 2021-12-03T00:06:25Z

Took a while to get the tests to work on a clean clone, but I got that going. I don't know why snapshot comparison requires slashes, but here's a screenshot of the test as expected.

.

mozeryansky · 2021-12-03T03:57:28Z

@timneutkens The test said it failed on the CI but when I run it locally it passes. I've rebased to the top of canary and pushed again, but I don't see any reason the test would have failed.

They all reported timeouts on the CI run:

...
thrown: "Exceeded timeout of 90000 ms for a hook.
 Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
...
Test Suites: 1 failed, 1 total
Tests:       102 failed, 102 total
Snapshots:   0 total
Time:        91.992 s, estimated 92 s
Ran all test suites matching /test\\integration\\production\\test\\index.test.js/i.

Passes for me:

Test Suites: 1 passed, 1 total
Tests:       103 passed, 103 total
Snapshots:   0 total
Time:        81.307 s, estimated 97 s
Ran all test suites matching /test\/integration\/production\/test\/index.test.js/i.

mozeryansky · 2021-12-03T07:22:53Z

I see the latest merges into canary are also failing the same azure tests.

mozeryansky · 2021-12-17T02:46:25Z

@timneutkens I've rebased but I see the tests are still failing the same way as other PRs. Could you help me with the next steps for this PR?

ijjk · 2022-01-10T19:29:13Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
buildDuration	16.9s	16.9s	⚠️ +12ms
buildDurationCached	3.8s	3.7s	-111ms
nodeModulesSize	355 MB	355 MB	⚠️ +162 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.407	3.448	⚠️ +0.04
/ avg req/sec	733.85	725.11	⚠️ -8.74
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.606	1.579	-0.03
/error-in-render avg req/sec	1556.61	1583.03	+26.42

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.1 kB	27.1 kB	⚠️ +6 B
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.9 kB	70.9 kB	⚠️ +6 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.74 kB	4.74 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
index.html gzip	532 B	532 B	✓
link.html gzip	546 B	547 B	⚠️ +1 B
withRouter.html gzip	527 B	527 B	✓
Overall change	1.6 kB	1.61 kB	⚠️ +1 B

Diffs

Diff for main-HASH.js

@@ -918,7 +918,7 @@
                       // This catches errors like throwing in the top level of a module
                       initialErr = (0, _isError).default(_ctx.t1)
                         ? _ctx.t1
-                        : new Error(_ctx.t1 + "");
+                        : new Error(JSON.stringify(_ctx.t1));
                     case 33:
                       if (false) {
                       }

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-65c45d624fc47f18.js"
+      src="/_next/static/chunks/main-c192afff05800900.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-65c45d624fc47f18.js"
+      src="/_next/static/chunks/main-c192afff05800900.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-65c45d624fc47f18.js"
+      src="/_next/static/chunks/main-c192afff05800900.js"
       defer=""
     ></script>
     <script

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
buildDuration	18.4s	18.6s	⚠️ +202ms
buildDurationCached	3.8s	3.7s	-97ms
nodeModulesSize	355 MB	355 MB	⚠️ +162 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.386	3.461	⚠️ +0.07
/ avg req/sec	738.41	722.33	⚠️ -16.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.528	1.571	⚠️ +0.04
/error-in-render avg req/sec	1636.21	1590.9	⚠️ -45.31

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	⚠️ +7 B
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.1 kB	71.1 kB	⚠️ +7 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	906 B	906 B	✓
image-HASH.js gzip	4.76 kB	4.76 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	mozeryansky/next.js michael/error	Change
index.html gzip	532 B	530 B	-2 B
link.html gzip	546 B	544 B	-2 B
withRouter.html gzip	526 B	525 B	-1 B
Overall change	1.6 kB	1.6 kB	-5 B

Diffs

Diff for main-HASH.js

@@ -918,7 +918,7 @@
                       // This catches errors like throwing in the top level of a module
                       initialErr = (0, _isError).default(_ctx.t1)
                         ? _ctx.t1
-                        : new Error(_ctx.t1 + "");
+                        : new Error(JSON.stringify(_ctx.t1));
                     case 33:
                       if (false) {
                       }

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-65c45d624fc47f18.js"
+      src="/_next/static/chunks/main-c192afff05800900.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-65c45d624fc47f18.js"
+      src="/_next/static/chunks/main-c192afff05800900.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-65c45d624fc47f18.js"
+      src="/_next/static/chunks/main-c192afff05800900.js"
       defer=""
     ></script>
     <script

Commit: 34b2ebc

ijjk

Hi, I opened an alternative/continuation of this PR here which adds a shared util for this and updates all cases to use this so we can change this easier. I copied over your commits so you're marked as a co-contributor on that PR. Thanks for taking a look at this!

mozeryansky · 2022-01-10T22:05:28Z

Hi, I opened an alternative/continuation of this PR here

Thanks! I had originally done a helper function in the exact same spot, but I reverted to changing each line when I was trying to figure out how the tests worked. Should I close this PR?

ijjk · 2022-01-11T00:25:57Z

I see, yeah we can close this one and continue in the other PR

mozeryansky requested review from huozhi, ijjk, shuding and timneutkens as code owners November 27, 2021 09:03

ijjk added the type: next label Nov 27, 2021

This comment has been minimized.

Sign in to view

timneutkens requested changes Nov 29, 2021

View reviewed changes

mozeryansky requested a review from timneutkens December 2, 2021 19:20

mozeryansky force-pushed the michael/error branch from 49c82ec to 14a8d1e Compare December 3, 2021 00:04

mozeryansky force-pushed the michael/error branch from 14a8d1e to 7e958c0 Compare December 3, 2021 03:45

mozeryansky force-pushed the michael/error branch 2 times, most recently from c2d3e8e to d9eb3d3 Compare December 16, 2021 22:47

mozeryansky closed this Dec 17, 2021

mozeryansky force-pushed the michael/error branch from d9eb3d3 to ed022ed Compare December 17, 2021 02:41

mozeryansky reopened this Dec 17, 2021

JSON.stringify generic errors

2ca072e

mozeryansky force-pushed the michael/error branch from 2d848f0 to 2ca072e Compare December 20, 2021 01:43

mozeryansky mentioned this pull request Jan 10, 2022

Custom error object appears as [Object object] #31670

Closed

Merge branch 'canary' into michael/error

34b2ebc

ijjk mentioned this pull request Jan 10, 2022

Add util for normalizing errors #33159

Merged

3 tasks

ijjk reviewed Jan 10, 2022

View reviewed changes

ijjk closed this Jan 11, 2022

vercel locked as resolved and limited conversation to collaborators Feb 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JSON.stringify generic errors #31866

JSON.stringify generic errors #31866

mozeryansky commented Nov 27, 2021

This comment has been minimized.

timneutkens left a comment

mozeryansky commented Dec 3, 2021 •

edited

mozeryansky commented Dec 3, 2021

mozeryansky commented Dec 3, 2021

mozeryansky commented Dec 17, 2021

ijjk commented Jan 10, 2022

Diffs

Diffs

ijjk left a comment

mozeryansky commented Jan 10, 2022

ijjk commented Jan 11, 2022

JSON.stringify generic errors #31866

JSON.stringify generic errors #31866

Conversation

mozeryansky commented Nov 27, 2021

This comment has been minimized.

timneutkens left a comment

Choose a reason for hiding this comment

mozeryansky commented Dec 3, 2021 • edited

mozeryansky commented Dec 3, 2021

mozeryansky commented Dec 3, 2021

mozeryansky commented Dec 17, 2021

ijjk commented Jan 10, 2022

Stats from current PR

Diffs

Diffs

ijjk left a comment

Choose a reason for hiding this comment

mozeryansky commented Jan 10, 2022

ijjk commented Jan 11, 2022

mozeryansky commented Dec 3, 2021 •

edited