Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webpack #31455

Merged
merged 7 commits into from Nov 16, 2021
Merged

update webpack #31455

merged 7 commits into from Nov 16, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 15, 2021

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 15, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as ready for review November 15, 2021 19:49
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 16, 2021

Failing test suites

Commit: a85e998

test/integration/css-modules/test/index.test.js

  • Has CSS Module in computed styles in Production > should have compiled successfully
  • Has CSS Module in computed styles in Production > should have CSS for page
Expand output

● Has CSS Module in computed styles in Production › should have compiled successfully

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  120 |     expect(cssPreload.length).toBe(1)
  121 |     expect(cssPreload.attr('href')).toMatch(/^\/_next\/static\/css\/.*\.css$/)
> 122 |
      | ^
  123 |     const cssSheet = $('link[rel="stylesheet"]')
  124 |     expect(cssSheet.length).toBe(1)
  125 |     expect(cssSheet.attr('href')).toMatch(/^\/_next\/static\/css\/.*\.css$/)

  at integration/css-modules/test/index.test.js:122:5
  at Object.<anonymous> (integration/css-modules/test/index.test.js:116:1)

● Has CSS Module in computed styles in Production › should have CSS for page

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  120 |     expect(cssPreload.length).toBe(1)
  121 |     expect(cssPreload.attr('href')).toMatch(/^\/_next\/static\/css\/.*\.css$/)
> 122 |
      | ^
  123 |     const cssSheet = $('link[rel="stylesheet"]')
  124 |     expect(cssSheet.length).toBe(1)
  125 |     expect(cssSheet.attr('href')).toMatch(/^\/_next\/static\/css\/.*\.css$/)

  at integration/css-modules/test/index.test.js:122:5
  at Object.<anonymous> (integration/css-modules/test/index.test.js:116:1)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  398 |   return new Promise((resolve, reject) => {
  399 |     const newArgs = [
> 400 |       ...args,
      |               ^
  401 |       function (err, res) {
  402 |         if (err) return reject(err)
  403 |         resolve(res)

  at Object.killApp (lib/next-test-utils.js:400:32)
  at integration/css-modules/test/index.test.js:131:35

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 19.8s 19.7s -115ms
buildDurationCached 3.8s 4s ⚠️ +164ms
nodeModulesSize 336 MB 336 MB ⚠️ +10.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 3.444 3.441 0
/ avg req/sec 725.9 726.62 +0.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.877 1.848 -0.03
/error-in-render avg req/sec 1331.96 1352.57 +20.61
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/update Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 21.4s 21.2s -259ms
buildDurationCached 3.7s 4s ⚠️ +324ms
nodeModulesSize 336 MB 336 MB ⚠️ +10.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 3.591 3.434 -0.16
/ avg req/sec 696.19 727.92 +31.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.841 1.873 ⚠️ +0.03
/error-in-render avg req/sec 1357.91 1334.56 ⚠️ -23.35
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/update Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: 0cddcc8

@kodiakhq kodiakhq bot merged commit bf97316 into canary Nov 16, 2021
@kodiakhq kodiakhq bot deleted the webpack/update branch November 16, 2021 17:28
@kaykdm kaykdm mentioned this pull request Dec 28, 2021
10 tasks
kodiakhq bot pushed a commit that referenced this pull request Jan 11, 2022
x-ref [#31552 ](#31552)
x-ref #32115
x-ref #32546
x-ref #32721

Since this PR #31455 is merged, `enhanced-resolve` dependency's resolved field is changed which caused broken yarn pnp.
I am not sure how this field has been changed or this is intentional or not 
When I install webpack locally, `enhanced-resolve`'s resolved field in lock file is always `registry.yarnpkg.com` not `codeload.github.com`

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants