Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ServerlessPlugin to use chunkGraph #31058

Merged
merged 3 commits into from Nov 6, 2021
Merged

Update ServerlessPlugin to use chunkGraph #31058

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f5e456
update serverless plugin to use webpack 5 apis
shuding Nov 5, 2021
4b40982
Merge branch 'canary' into shu/04dd
shuding Nov 5, 2021
584e023
Merge branch 'canary' into shu/04dd
kodiakhq[bot] Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/next/build/webpack/plugins/serverless-plugin.ts
View file
Open in desktop
Expand Up @@ -14,7 +14,8 @@ export class ServerlessPlugin {
hook.tap('ServerlessPlugin', (chunks) => {
for (const chunk of chunks) {
// If chunk is not an entry point skip them
if (!chunk.hasEntryModule()) {
// @ts-ignore TODO: Remove ignore when webpack 5 is stable
if (compilation.chunkGraph.getNumberOfEntryModules(chunk) === 0) {
continue
}

Expand All @@ -26,7 +27,11 @@ export class ServerlessPlugin {
dynamicChunk
)) {
// Add module back into the entry chunk
chunk.addModule(module)
// @ts-ignore TODO: Remove ignore when webpack 5 is stable
if (!compilation.chunkGraph.isModuleInChunk(module, chunk)) {
// @ts-ignore TODO: Remove ignore when webpack 5 is stable
compilation.chunkGraph.connectChunkAndModule(chunk, module)
}
}
}
}
Expand Down