Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure dev react bundles are not ignored in traces #30849

Merged
merged 4 commits into from
Nov 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 2, 2021

This removes the ignores for dev react bundles which was added as an optimization but causes issues when react is imported from an ESM module since all requires are being analyzed for named exports. Thanks to @sokra for the find!

x-ref: #30750

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

styfle
styfle previously approved these changes Nov 2, 2021
@ijjk

This comment has been minimized.

styfle
styfle previously approved these changes Nov 2, 2021
@ijjk
Copy link
Member Author

ijjk commented Nov 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
buildDuration 26.3s 26.6s ⚠️ +336ms
buildDurationCached 5.4s 5.4s ⚠️ +20ms
nodeModulesSize 293 MB 293 MB -391 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
/ failed reqs 0 0
/ total time (seconds) 4.39 4.121 -0.27
/ avg req/sec 569.52 606.71 +37.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.243 2.199 -0.04
/error-in-render avg req/sec 1114.65 1137.08 +22.43
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
index.html gzip 521 B 521 B
link.html gzip 533 B 533 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
buildDuration 29s 28.5s -515ms
buildDurationCached 5.5s 5.4s -139ms
nodeModulesSize 293 MB 293 MB -391 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
/ failed reqs 0 0
/ total time (seconds) 4.3 4.252 -0.05
/ avg req/sec 581.41 588.01 +6.6
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.262 2.238 -0.02
/error-in-render avg req/sec 1105.44 1116.85 +11.41
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/remove-dev-ignores Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: f6e9e64

@ijjk ijjk merged commit 507ac98 into vercel:canary Nov 3, 2021
@ijjk ijjk deleted the fix/remove-dev-ignores branch November 3, 2021 00:02
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants