Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update font-stylesheet-gathering-plugin.ts #30709

Merged
merged 5 commits into from Feb 6, 2022
Merged

Update font-stylesheet-gathering-plugin.ts #30709

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b3e1b4
Update font-stylesheet-gathering-plugin.ts
pklawansky Oct 31, 2021
eabba8a
Merge branch 'canary' into patch-1
ijjk Feb 6, 2022
7a9ca62
ensure font css minimizing errors are caught/logged
ijjk Feb 6, 2022
ecc9f87
Merge branch 'canary' into patch-1
ijjk Feb 6, 2022
77b6c79
Merge branch 'canary' into patch-1
kodiakhq[bot] Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/next/build/webpack/plugins/font-stylesheet-gathering-plugin.ts
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ import {
FONT_MANIFEST,
OPTIMIZED_FONT_PROVIDERS,
} from '../../../shared/lib/constants'
import * as Log from '../../output/log'

function minifyCss(css: string): Promise<string> {
return postcss([
Expand Down Expand Up @@ -197,11 +198,18 @@ export class FontStylesheetGatheringPlugin {
const css = await fontDefinitionPromises[promiseIndex]

if (css) {
const content = await minifyCss(css)
this.manifestContent.push({
url: fontStylesheets[promiseIndex],
content,
})
try {
const content = await minifyCss(css)
this.manifestContent.push({
url: fontStylesheets[promiseIndex],
content,
})
} catch (err) {
Log.warn(
`Failed to minify the stylesheet for ${fontStylesheets[promiseIndex]}. Skipped optimizing this font.`
)
console.error(err)
}
}
}

Expand Down