Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NEXT_PHASE env change in workers #28941

Merged
merged 3 commits into from Dec 16, 2021
Merged

Prevent NEXT_PHASE env change in workers #28941

merged 3 commits into from Dec 16, 2021

Commits on Sep 8, 2021

  1. Restore NEXT_PHASE 

    `process.env.NEXT_PHASE` was moved in vercel#20900 to be set during `staticCheckSpan.traceAsyncFn`. I believe this to be a mistake, the NEXT_PHASE should be set earlier in the code execution.

On a personal note, this impacts an application I am developing where we rely on the environment variable `NEXT_PHASE` to be set but is `undefined` when we check it.
    @jbraithwaite
    jbraithwaite committed Sep 8, 2021
    Copy the full SHA
    ac4acf2 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Merge branch 'canary' into jb/fix-next-phase

    @jbraithwaite
    jbraithwaite committed Sep 10, 2021
    Copy the full SHA
    6982dd7 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Merge branch 'canary' into jb/fix-next-phase 

    # Conflicts:
#	packages/next/build/index.ts
    @ijjk
    ijjk committed Dec 16, 2021
    Copy the full SHA
    02279fb View commit details
    Browse the repository at this point in the history