Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure @babel/core is not duplicated #28716

Merged
merged 6 commits into from Sep 1, 2021
Merged

Ensure @babel/core is not duplicated #28716

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7da05d5
Ensure @babel/core is not duplicated
ijjk Sep 1, 2021
5226285
remove packageName/bundleName
ijjk Sep 1, 2021
93ee5e6
update compiled
ijjk Sep 1, 2021
d889b44
ensure bundle resolves correctly
ijjk Sep 1, 2021
196375c
fix
ijjk Sep 1, 2021
bb2c702
fix eslint-disable
ijjk Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/compiled/babel-packages/package.json
View file
Open in desktop
@@ -1 +1 @@
{"name":"@babel/core","main":"packages-bundle.js","author":"The Babel Team (https://babel.dev/team)","license":"MIT"}
{"name":"@babel/preset-env","main":"packages-bundle.js","author":"The Babel Team (https://babel.dev/team)","license":"MIT"}
ijjk marked this conversation as resolved.
Show resolved Hide resolved
11,993 changes: 359 additions & 11,634 deletions packages/next/compiled/babel-packages/packages-bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion packages/next/taskfile.js
View file
Open in desktop
Expand Up @@ -155,7 +155,10 @@ export async function ncc_babel_bundle_packages(task, opts) {
await task
.source(opts.src || 'bundles/babel/packages-bundle.js')
.ncc({
packageName: `@babel/core`,
// note: this packageName can not be the name of
// an externals package or else it will not be
// externalized by ncc
packageName: `@babel/preset-env`,
ijjk marked this conversation as resolved.
Show resolved Hide resolved
bundleName: 'babel-packages',
externals: externals,
})
Expand Down