Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure @babel/types is not duplicated #28713

Merged
merged 3 commits into from Sep 1, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 1, 2021

This is a follow-up to #28174 to ensure we de-dupe @babel/types correctly as this increased the compiled babel packages quite a bit.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 1, 2021
@ijjk ijjk marked this pull request as ready for review September 1, 2021 17:04
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Sep 1, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
buildDuration 14.2s 13.4s -828ms
buildDurationCached 3.3s 3.3s -24ms
nodeModulesSize 61.7 MB 53.3 MB -8.41 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
/ failed reqs 0 0
/ total time (seconds) 2.683 2.551 -0.13
/ avg req/sec 931.7 979.82 +48.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.383 1.384 0
/error-in-render avg req/sec 1808.13 1806.63 ⚠️ -1.5
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
buildDuration 11.8s 11.1s -703ms
buildDurationCached 5.1s 4.6s -488ms
nodeModulesSize 61.7 MB 53.3 MB -8.41 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
/ failed reqs 0 0
/ total time (seconds) 2.617 2.623 ⚠️ +0.01
/ avg req/sec 955.33 953.21 ⚠️ -2.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.436 1.442 ⚠️ +0.01
/error-in-render avg req/sec 1740.98 1733.88 ⚠️ -7.1
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/babel-types-duplicate Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 8ea2098

@kodiakhq kodiakhq bot merged commit 77c0e09 into vercel:canary Sep 1, 2021
@ijjk ijjk deleted the fix/babel-types-duplicate branch September 1, 2021 17:54
kodiakhq bot pushed a commit that referenced this pull request Sep 1, 2021
Follow-up to #28713 this ensures we also don't duplicate `@babel/core` in our `babel-packages` bundle. This was occurring from us re-using the `@babel/core` package name which causes us to remove it from the externals [here](https://github.com/vercel/next.js/blob/77c0e0937128409960ee48ee965501f4d18c9c82/packages/next/taskfile-ncc.js#L18-L21).
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants