Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix development mode bug with pages with "+" and other special characters #28122

Merged
merged 3 commits into from Aug 17, 2021
Merged

fix development mode bug with pages with "+" and other special characters #28122

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8bdf38
add encodeURIComponent so certain characters don't bug out (fixes #22…
Aug 15, 2021
4a7588c
add integration test for pr #28122
Aug 16, 2021
8c8f57d
Merge branch 'canary' into dev-url-special-chars
kodiakhq[bot] Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/next/client/dev/on-demand-entries-utils.js
View file
Open in desktop
Expand Up @@ -19,7 +19,9 @@ export function setupPing(assetPrefix, pathnameFn, retry) {
closePing()

evtSource = getEventSourceWrapper({
path: `${assetPrefix}/_next/webpack-hmr?page=${currentPage}`,
path: `${assetPrefix}/_next/webpack-hmr?page=${encodeURIComponent(
currentPage
)}`,
timeout: 5000,
})

Expand Down