New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dynamic HTML #28085
Merged
Merged
Add support for dynamic HTML #28085
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d7e2ad1
Add renderToStream
devknoll 52048eb
Support dynamic HTML too
devknoll c370d0d
More resiliency
devknoll 4f65cdd
Make it nicer
devknoll 01fd330
More clean up
devknoll ed3d640
More clean up
devknoll 6239246
Clean up result
devknoll d17b6b5
Fix lint
devknoll File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,12 +16,13 @@ export function cleanAmpPath(pathname: string): string { | |
} | ||
|
||
export type Disposable = () => void | ||
// TODO: Consider just using an actual Observable here | ||
export type RenderResult = (observer: { | ||
next(chunk: string): void | ||
export type Observer<T> = { | ||
next(chunk: T): void | ||
error(error: Error): void | ||
complete(): void | ||
}) => Disposable | ||
} | ||
// TODO: Consider just using an actual Observable here | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this comment still needed? |
||
export type RenderResult = (observer: Observer<string>) => Disposable | ||
|
||
export function resultFromChunks(chunks: string[]): RenderResult { | ||
return ({ next, complete, error }) => { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it need a try-catch here like line