Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require component rendered as child of Link to pass event to onClick handler #27723

Merged
merged 3 commits into from Feb 7, 2022
Merged

Require component rendered as child of Link to pass event to onClick handler #27723

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb9a687
Require component rendered as child of `Link` to pass event to `onCli…
pie6k Aug 3, 2021
70536b9
Merge branch 'canary' into patch-1
ijjk Feb 6, 2022
cf44f9b
Update check and add test
ijjk Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/next/client/link.tsx
View file
Open in desktop
Expand Up @@ -282,6 +282,11 @@ function Link(props: React.PropsWithChildren<LinkProps>) {
} = {
ref: setRef,
onClick: (e: React.MouseEvent) => {
if (!e) {
if (process.env.NODE_ENV !== 'production') {
ijjk marked this conversation as resolved.
Show resolved Hide resolved
throw new Error(`Component rendered inside Link has to pass click event to "onClick" prop.`)
}
}
if (child.props && typeof child.props.onClick === 'function') {
child.props.onClick(e)
}
Expand Down