Update next-image-unconfigured-host.md #24953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the docs are misleading because I tried this and still got yelled at by compiler, and then added domains and it worked?
jflayhart
requested review from
divmain,
ijjk,
lfades,
shuding and
timneutkens
as code owners
|
actually some of this im experiencing is related to: #23590 but i still think clarifying these docs is helpful. |
ijjk
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Looks good to me, I went ahead and removed the docker note from this PR since we have explicit docker deployment docs here https://nextjs.org/docs/deployment#docker-image now, if it makes sense to still add this note it would probably be good to do so there.
Thanks for the PR!
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
* Update next-image-unconfigured-host.md the docs are misleading because I tried this and still got yelled at by compiler, and then added domains and it worked? * Update next-image-unconfigured-host.md * Update next-image-unconfigured-host.md * Update next-image-unconfigured-host.md * Update next-image-unconfigured-host.md * Update next-image-unconfigured-host.md * Update next-image-unconfigured-host.md * remove unrelated section Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
Do I use
hostnameordomains? I may never know because the docs tell me to do one thing, yet I got yelled at by compiler, and then I addeddomainsand it still doesn't work? 🤷🏻♂️EDIT: Also, we use docker with a custom next config, so making a note about making sure to copy over next.config.js to be compatible for runtime config.