Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark this.router protected #23573

Merged
merged 4 commits into from Mar 31, 2021
Merged

Mark this.router protected #23573

merged 4 commits into from Mar 31, 2021

Commits on Mar 31, 2021

  1. Mark this.router protected 

    Seems that some people (vercel#23558) are using Next.js internals based on the typings that TS generates automatically even though these values are not documented / should not be used in applications. This ensures the router value on Server is not used by accident.
    @timneutkens
    timneutkens committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    d7cf1f3 View commit details
    Browse the repository at this point in the history

  2. Mark all variables as protected 

    vercel#23349
    @timneutkens
    timneutkens committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    8a8a875 View commit details
    Browse the repository at this point in the history

  3. fix type error

    @ijjk
    ijjk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    126cc0b View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/canary' into add/make-router-p… 

    …rotected
    @ijjk
    ijjk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    89a73e5 View commit details
    Browse the repository at this point in the history