Fix typescript-eslint-jest example to remove Prettier package causing errors #22452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove "prettier/@typescript-eslint" from .eslintrc.json. After update to the last version I getting this error on running lint: ESLint couldn't find the config "prettier/@typescript-eslint" to extend from. I explore this issue prettier/eslint-config-prettier#175 and I think those extensions aren't needed anymore.
rsipakov
requested review from
divmain,
ijjk,
leerob,
lfades,
Timer and
timneutkens
as code owners
leerob
reviewed
Mar 1, 2021
| @@ -8,7 +8,7 @@ | |||
| // Uncomment the following lines to enable eslint-config-prettier | |||
| // Is not enabled right now to avoid issues with the Next.js repo | |||
| // "prettier", | |||
| // "prettier/@typescript-eslint" | |||
| // "prettier/@typescript-eslint" // delete according to this information https://github.com/prettier/eslint-config-prettier/pull/175 | |||
There was a problem hiding this comment.
Wouldn't we just delete this line?
There was a problem hiding this comment.
Yes, I think this is the best option.
leerob
reviewed
Mar 1, 2021
leerob
approved these changes
Mar 1, 2021
leerob
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete "prettier/@typescript-eslint" from .eslintrc.json.
After update to the last version I getting this error on running lint: ESLint couldn't find the config "prettier/@typescript-eslint" to extend from.
I explore this issue prettier/eslint-config-prettier#175 and I think those extensions aren't needed anymore.