Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace raw-body with get-stream and bytes #21915

Merged
merged 7 commits into from Dec 8, 2021

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Feb 6, 2021

get-stream is small library without dependencies for resolving streams
as promise.

https://packagephobia.com/result?p=raw-body
https://packagephobia.com/result?p=get-stream
https://packagephobia.com/result?p=bytes

@ijjk
Copy link
Member

ijjk commented Feb 6, 2021

Failing test suites

Commit: 2576be7

test/integration/api-support/test/index.test.js

  • API routes > Server support > should return error exceeded body limit
  • API routes > Serverless support > should return error exceeded body limit
  • API routes > dev support > should return error exceeded body limit
Expand output

● API routes › dev support › should return error exceeded body limit

expect(received).toEqual(expected) // deep equality

Expected: 413
Received: 400

  165 |       expect(error.code).toBe('EPIPE')
  166 |     } else {
> 167 |       expect(res.status).toEqual(413)
      |                          ^
  168 |       expect(res.statusText).toEqual('Body exceeded 1mb limit')
  169 |     }
  170 |   })

  at Object.<anonymous> (integration/api-support/test/index.test.js:167:26)

● API routes › Server support › should return error exceeded body limit

expect(received).toEqual(expected) // deep equality

Expected: 413
Received: 400

  165 |       expect(error.code).toBe('EPIPE')
  166 |     } else {
> 167 |       expect(res.status).toEqual(413)
      |                          ^
  168 |       expect(res.statusText).toEqual('Body exceeded 1mb limit')
  169 |     }
  170 |   })

  at Object.<anonymous> (integration/api-support/test/index.test.js:167:26)

● API routes › Serverless support › should return error exceeded body limit

expect(received).toEqual(expected) // deep equality

Expected: 413
Received: 400

  165 |       expect(error.code).toBe('EPIPE')
  166 |     } else {
> 167 |       expect(res.status).toEqual(413)
      |                          ^
  168 |       expect(res.statusText).toEqual('Body exceeded 1mb limit')
  169 |     }
  170 |   })

  at Object.<anonymous> (integration/api-support/test/index.test.js:167:26)

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

styfle
styfle previously approved these changes Nov 2, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

timneutkens
timneutkens previously approved these changes Nov 3, 2021
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Could you fix the merge conflict, then this can be landed 🙏

@timneutkens timneutkens dismissed stale reviews from styfle and themself via 314c126 December 7, 2021 18:22
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@timneutkens timneutkens changed the title [next] replace raw-body with get-stream and bytes Replace raw-body with get-stream and bytes Dec 7, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 8, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js get-stream Change
buildDuration 17.8s 17.8s -61ms
buildDurationCached 3.3s 3.3s -11ms
nodeModulesSize 347 MB 347 MB -417 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TrySound/next.js get-stream Change
/ failed reqs 0 0
/ total time (seconds) 2.938 2.927 -0.01
/ avg req/sec 850.82 854.1 +3.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.329 1.332 0
/error-in-render avg req/sec 1880.54 1876.88 ⚠️ -3.66
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js get-stream Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js get-stream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js get-stream Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js get-stream Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary TrySound/next.js get-stream Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js get-stream Change
buildDuration 19.4s 19.3s -145ms
buildDurationCached 3.3s 3.4s ⚠️ +29ms
nodeModulesSize 347 MB 347 MB -417 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TrySound/next.js get-stream Change
/ failed reqs 0 0
/ total time (seconds) 2.939 2.915 -0.02
/ avg req/sec 850.51 857.77 +7.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.347 1.36 ⚠️ +0.01
/error-in-render avg req/sec 1856.04 1837.73 ⚠️ -18.31
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js get-stream Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js get-stream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary TrySound/next.js get-stream Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary TrySound/next.js get-stream Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary TrySound/next.js get-stream Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: ef22faa

@timneutkens timneutkens merged commit 6687b09 into vercel:canary Dec 8, 2021
styfle added a commit that referenced this pull request Dec 8, 2021
kodiakhq bot pushed a commit that referenced this pull request Dec 8, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants