Fix buildmanifest for webpack 5 splitchunks #21325

timneutkens · 2021-01-19T11:28:55Z

Fixes an edge case introduced in #21208

Fixes an edge case introduced in vercel#21208

ijjk · 2021-01-19T12:54:09Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
buildDuration	10.2s	10.2s	-16ms
nodeModulesSize	77.6 MB	77.6 MB	⚠️ +241 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.97	1.951	-0.02
/ avg req/sec	1269	1281.41	+12.41
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.212	1.216	0
/error-in-render avg req/sec	2063.54	2056.17	⚠️ -7.37

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Diffs

Diff for index.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
+      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
+      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
       as="script"
     />
     <link
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-b9cf267ce11e4373e54e.js"
       async=""

Diff for link.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
+      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
+      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
       as="script"
     />
     <link
@@ -57,10 +57,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       async=""
@@ -73,6 +69,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-b9cf267ce11e4373e54e.js"
       async=""

Diff for withRouter.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
+      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
+      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
       as="script"
     />
     <link
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-d0ca4c755b62bd05137c.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-b9cf267ce11e4373e54e.js"
       async=""

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
buildDuration	12.2s	11.9s	-312ms
nodeModulesSize	77.6 MB	77.6 MB	⚠️ +241 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_error.js	1 MB	1.01 MB	⚠️ +1.29 kB
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1.01 MB	⚠️ +1.29 kB
link.js	1.06 MB	1.06 MB	⚠️ +1.29 kB
routerDirect.js	1.05 MB	1.06 MB	⚠️ +1.29 kB
withRouter.js	1.05 MB	1.06 MB	⚠️ +1.29 kB
Overall change	5.18 MB	5.19 MB	⚠️ +6.47 kB

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
buildDuration	12.6s	12.6s	⚠️ +4ms
nodeModulesSize	77.6 MB	77.6 MB	⚠️ +241 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.018	1.981	-0.04
/ avg req/sec	1238.94	1261.73	+22.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.301	1.258	-0.04
/error-in-render avg req/sec	1922.09	1987.52	+65.43

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
597-3bd7d6bd..868b.js gzip	13 kB	13 kB	✓
778-d412f8e7..3ee1.js gzip	6.56 kB	6.56 kB	✓
838-adcbad39..6e83.js gzip	31.1 kB	31.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-6a6a792..6877.js gzip	96 B	96 B	✓
webpack-e302..54e9.js gzip	954 B	954 B	✓
Overall change	91 kB	91 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
polyfills-a0..538c.js gzip	88 B	88 B	✓
Overall change	88 B	88 B	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
index.html gzip	585 B	629 B	⚠️ +44 B
link.html gzip	592 B	637 B	⚠️ +45 B
withRouter.html gzip	581 B	625 B	⚠️ +44 B
Overall change	1.76 kB	1.89 kB	⚠️ +133 B

Diffs

Diff for index.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
+      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
+      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Hde7oUwRKQPu-Ff7JIrIQ",
+        "buildId": "BbbEZCqPspeNrZx0sda9s",
         "isFallback": false,
         "gip": true
       }
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-af28de04c604a2479390.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-2a09aa2580945cbf4a98.js"
       async=""
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Hde7oUwRKQPu-Ff7JIrIQ/_buildManifest.js"
+      src="/_next/static/BbbEZCqPspeNrZx0sda9s/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Hde7oUwRKQPu-Ff7JIrIQ/_ssgManifest.js"
+      src="/_next/static/BbbEZCqPspeNrZx0sda9s/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
+      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
+      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Hde7oUwRKQPu-Ff7JIrIQ",
+        "buildId": "BbbEZCqPspeNrZx0sda9s",
         "isFallback": false,
         "gip": true
       }
@@ -57,10 +57,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-af28de04c604a2479390.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       async=""
@@ -73,6 +69,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-2a09aa2580945cbf4a98.js"
       async=""
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Hde7oUwRKQPu-Ff7JIrIQ/_buildManifest.js"
+      src="/_next/static/BbbEZCqPspeNrZx0sda9s/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Hde7oUwRKQPu-Ff7JIrIQ/_ssgManifest.js"
+      src="/_next/static/BbbEZCqPspeNrZx0sda9s/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
+      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
+      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Hde7oUwRKQPu-Ff7JIrIQ",
+        "buildId": "BbbEZCqPspeNrZx0sda9s",
         "isFallback": false,
         "gip": true
       }
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-af28de04c604a2479390.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-9e3e4e63bcbbf1952023.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-2a09aa2580945cbf4a98.js"
       async=""
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Hde7oUwRKQPu-Ff7JIrIQ/_buildManifest.js"
+      src="/_next/static/BbbEZCqPspeNrZx0sda9s/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Hde7oUwRKQPu-Ff7JIrIQ/_ssgManifest.js"
+      src="/_next/static/BbbEZCqPspeNrZx0sda9s/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: eff8a06

timneutkens · 2021-01-19T12:59:43Z

This would explain the 88b polyfills report, which is incorrect. The file is split out into more bundles.

ijjk · 2021-01-20T09:38:43Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
buildDuration	7.7s	7.8s	⚠️ +104ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +241 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.603	1.592	-0.01
/ avg req/sec	1559.75	1570.04	+10.29
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.97	1.008	⚠️ +0.04
/error-in-render avg req/sec	2576.85	2481.21	⚠️ -95.64

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
index.html gzip	616 B	616 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	609 B	609 B	✓
Overall change	1.85 kB	1.85 kB	✓

Diffs

Diff for index.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-039d3df776c23de90078.js"
+      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
+      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/main-039d3df776c23de90078.js"
       as="script"
     />
     <link
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-039d3df776c23de90078.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-039d3df776c23de90078.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-b9cf267ce11e4373e54e.js"
       async=""

Diff for link.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-039d3df776c23de90078.js"
+      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
+      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/main-039d3df776c23de90078.js"
       as="script"
     />
     <link
@@ -57,10 +57,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-039d3df776c23de90078.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       async=""
@@ -73,6 +69,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-039d3df776c23de90078.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-b9cf267ce11e4373e54e.js"
       async=""

Diff for withRouter.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-039d3df776c23de90078.js"
+      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
+      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.c2766659ac6e6a63ca79.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/main-039d3df776c23de90078.js"
       as="script"
     />
     <link
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-039d3df776c23de90078.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-becabbdf5d4df28a038e.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-039d3df776c23de90078.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-b9cf267ce11e4373e54e.js"
       async=""

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
buildDuration	11s	10.8s	-219ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +241 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_error.js	1 MB	1.01 MB	⚠️ +1.29 kB
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1.01 MB	⚠️ +1.29 kB
link.js	1.06 MB	1.06 MB	⚠️ +1.29 kB
routerDirect.js	1.05 MB	1.06 MB	⚠️ +1.29 kB
withRouter.js	1.05 MB	1.06 MB	⚠️ +1.29 kB
Overall change	5.19 MB	5.19 MB	⚠️ +6.47 kB

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
buildDuration	10.8s	10.4s	-396ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +241 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.778	1.643	-0.13
/ avg req/sec	1406.36	1521.27	+114.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.2	1.028	-0.17
/error-in-render avg req/sec	2083	2431.96	+348.96

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
597-3bd7d6bd..868b.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js fix/webpack5-splitchunks	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	591 B	-1 B
withRouter.html gzip	579 B	579 B	✓
Overall change	1.76 kB	1.75 kB	-1 B

Diffs

Diff for index.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
+      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
+      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "o17Kz6L-ovhUzyYhQB-7a",
+        "buildId": "zqOxDEUslsN-L4iwAQCm-",
         "isFallback": false,
         "gip": true
       }
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-af28de04c604a2479390.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-2a09aa2580945cbf4a98.js"
       async=""
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/o17Kz6L-ovhUzyYhQB-7a/_buildManifest.js"
+      src="/_next/static/zqOxDEUslsN-L4iwAQCm-/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/o17Kz6L-ovhUzyYhQB-7a/_ssgManifest.js"
+      src="/_next/static/zqOxDEUslsN-L4iwAQCm-/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
+      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
+      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "o17Kz6L-ovhUzyYhQB-7a",
+        "buildId": "zqOxDEUslsN-L4iwAQCm-",
         "isFallback": false,
         "gip": true
       }
@@ -57,10 +57,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-af28de04c604a2479390.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       async=""
@@ -73,6 +69,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-2a09aa2580945cbf4a98.js"
       async=""
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/o17Kz6L-ovhUzyYhQB-7a/_buildManifest.js"
+      src="/_next/static/zqOxDEUslsN-L4iwAQCm-/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/o17Kz6L-ovhUzyYhQB-7a/_ssgManifest.js"
+      src="/_next/static/zqOxDEUslsN-L4iwAQCm-/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,22 +7,22 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
+      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
+      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/framework.dc46d8e6c07122d5fb16.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       as="script"
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "o17Kz6L-ovhUzyYhQB-7a",
+        "buildId": "zqOxDEUslsN-L4iwAQCm-",
         "isFallback": false,
         "gip": true
       }
@@ -52,10 +52,6 @@
       nomodule=""
       src="/_next/static/chunks/polyfills-af28de04c604a2479390.js"
     ></script>
-    <script
-      src="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
-      async=""
-    ></script>
     <script
       src="/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js"
       async=""
@@ -68,6 +64,10 @@
       src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
       async=""
     ></script>
+    <script
+      src="/_next/static/chunks/main-7173c7aaeb94288e5604.js"
+      async=""
+    ></script>
     <script
       src="/_next/static/chunks/pages/_app-2a09aa2580945cbf4a98.js"
       async=""
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/o17Kz6L-ovhUzyYhQB-7a/_buildManifest.js"
+      src="/_next/static/zqOxDEUslsN-L4iwAQCm-/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/o17Kz6L-ovhUzyYhQB-7a/_ssgManifest.js"
+      src="/_next/static/zqOxDEUslsN-L4iwAQCm-/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: ea7dcfd

Timer

Blocking this temporarily while so we can adjust the polyfill chunk handling.

Also, the react refresh chunk handling can probably be tweaked, too.

Fix buildmanifest for webpack 5 splitchunks

4fcbb55

Fixes an edge case introduced in vercel#21208

timneutkens requested review from ijjk, lfades and Timer as code owners January 19, 2021 11:28

This comment has been minimized.

Sign in to view

Exclude webpack runtime from polyfills files

7025254

ijjk added the type: next label Jan 19, 2021

This comment has been minimized.

Sign in to view

Exclude webpack chunk from devFiles too

eff8a06

Merge branch 'canary' into fix/webpack5-splitchunks

ea7dcfd

Timer requested changes Jan 20, 2021

View reviewed changes

timneutkens closed this Feb 12, 2021

timneutkens deleted the fix/webpack5-splitchunks branch February 12, 2021 13:33

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix buildmanifest for webpack 5 splitchunks #21325

Fix buildmanifest for webpack 5 splitchunks #21325

timneutkens commented Jan 19, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 19, 2021

Diffs

Diffs

timneutkens commented Jan 19, 2021

ijjk commented Jan 20, 2021

Diffs

Diffs

Timer left a comment

Fix buildmanifest for webpack 5 splitchunks #21325

Fix buildmanifest for webpack 5 splitchunks #21325

Conversation

timneutkens commented Jan 19, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 19, 2021

Stats from current PR

Diffs

Diffs

timneutkens commented Jan 19, 2021

ijjk commented Jan 20, 2021

Stats from current PR

Diffs

Diffs

Timer left a comment

Choose a reason for hiding this comment