Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hydration mis-match test suite #21264

Merged
merged 1 commit into from Jan 18, 2021
Merged

Move hydration mis-match test suite #21264

merged 1 commit into from Jan 18, 2021

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Jan 18, 2021

In this PR, it was suggested to move the test suite, but it was merged before fixing.
This is the fix for that, moving link-with-hash test suite to client-navigation suite

detail: https://github.com/vercel/next.js/pull/21065/files#r558425551

@ijjk
Copy link
Member

ijjk commented Jan 18, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
buildDuration 10.1s 10.5s ⚠️ +409ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.016 2.038 ⚠️ +0.02
/ avg req/sec 1239.82 1226.64 ⚠️ -13.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.262 1.246 -0.02
/error-in-render avg req/sec 1980.81 2006.29 +25.48
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
buildDuration 12.2s 12.2s ⚠️ +33ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
buildDuration 12.6s 12.6s -58ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.015 2.086 ⚠️ +0.07
/ avg req/sec 1240.86 1198.67 ⚠️ -42.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.306 1.263 -0.04
/error-in-render avg req/sec 1914.48 1979.75 +65.27
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/move-hash-hydration-test Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "4auMO0xnY4Pp_B1ZQxkxe",
+        "buildId": "rFqr7aWt7T4I20U9GvqoY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/4auMO0xnY4Pp_B1ZQxkxe/_buildManifest.js"
+      src="/_next/static/rFqr7aWt7T4I20U9GvqoY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/4auMO0xnY4Pp_B1ZQxkxe/_ssgManifest.js"
+      src="/_next/static/rFqr7aWt7T4I20U9GvqoY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "4auMO0xnY4Pp_B1ZQxkxe",
+        "buildId": "rFqr7aWt7T4I20U9GvqoY",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/4auMO0xnY4Pp_B1ZQxkxe/_buildManifest.js"
+      src="/_next/static/rFqr7aWt7T4I20U9GvqoY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/4auMO0xnY4Pp_B1ZQxkxe/_ssgManifest.js"
+      src="/_next/static/rFqr7aWt7T4I20U9GvqoY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "4auMO0xnY4Pp_B1ZQxkxe",
+        "buildId": "rFqr7aWt7T4I20U9GvqoY",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/4auMO0xnY4Pp_B1ZQxkxe/_buildManifest.js"
+      src="/_next/static/rFqr7aWt7T4I20U9GvqoY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/4auMO0xnY4Pp_B1ZQxkxe/_ssgManifest.js"
+      src="/_next/static/rFqr7aWt7T4I20U9GvqoY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: efa75fd

ijjk
ijjk approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 699a7ae into vercel:canary Jan 18, 2021
@kaykdm kaykdm deleted the fix/move-hash-hydration-test branch January 18, 2021 04:57
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaykdm @ijjk