Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hydration mismatch on href for url with anchor refs #21065

Merged
merged 6 commits into from Jan 15, 2021
Merged

fix hydration mismatch on href for url with anchor refs #21065

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90273a9
fix hydration mismatch on href for url with anchor refs
Jan 13, 2021
fc98fde
add test
Jan 14, 2021
f13e7df
read browser logs from webdriver for test
Jan 15, 2021
00c0906
Update test/integration/link-with-hash/test/index.test.js
kaykdm Jan 15, 2021
6957e0c
Merge branch 'canary' into fix/hydration-mismatch-href
kodiakhq[bot] Jan 15, 2021
c2f27b8
fix lint
Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/next/next-server/lib/router/router.ts
View file
Open in desktop
Expand Up @@ -163,7 +163,8 @@ export function delBasePath(path: string): string {
* Detects whether a given url is routable by the Next.js router (browser only).
*/
export function isLocalURL(url: string): boolean {
if (url.startsWith('/')) return true
// prevent a hydration mismatch on href for url with anchor refs
if (url.startsWith('/') || url.startsWith('#')) return true
try {
// absolute urls can be local if they are on the same origin
const locationOrigin = getLocationOrigin()
Expand Down