Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use require.resolve to detect "framework" packages (fix pnpm) #21048
Use require.resolve to detect "framework" packages (fix pnpm) #21048
Changes from 1 commit
3740547
f785c27
e9c6cc0
3502549
a9c2ec8
c67d0aa
0a347ed
edbf543
c308764
7e9970d
f5594df
218a400
8b539e3
fae174b
f4f0d5e
3228ceb
6dd774b
4450a12
41d25a9
16b2443
5f96288
a9904ca
ed1800f
43dce85
758ac4f
c097bb2
c25339b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prop-types seem to be missing here?
It was part of the original regexp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also
react
andreact-dom
depend onobject-assign
so that might also need to be added here, even if it wasn't part of the regexp before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prop-types should be no longer needed since
next
no longer declares a direct dep onprop-types
. See 4450a12 and c7e2a1dI'll add object-assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, this error is raised when
getPackagePath('prop-types', dir)
is added to the array: