Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default development hostname to 127.0.0.1 #20156

Closed
wants to merge 1 commit into from

Conversation

Flaque
Copy link

@Flaque Flaque commented Dec 13, 2020

Overview

This makes the default host for the development environment 127.0.0.1:3000 instead of *:3000, which better matches the output started server on http://localhost:3000.

It fixes #20137, as suggested by @rsms on twitter.

@vercel vercel bot temporarily deployed to Preview December 13, 2020 23:04 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 13, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary getroomservice/next.js rs/local-conns Change
buildDuration 8.8s 8.8s ⚠️ +27ms
nodeModulesSize 82.4 MB 82.4 MB ⚠️ +40 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary getroomservice/next.js rs/local-conns Change
/ failed reqs 0 0
/ total time (seconds) 2.014 2.047 ⚠️ +0.03
/ avg req/sec 1241.16 1221.2 ⚠️ -19.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.091 1.1 ⚠️ +0.01
/error-in-render avg req/sec 2291.46 2272.49 ⚠️ -18.97
Client Bundles (main, webpack, commons)
vercel/next.js canary getroomservice/next.js rs/local-conns Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary getroomservice/next.js rs/local-conns Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary getroomservice/next.js rs/local-conns Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary getroomservice/next.js rs/local-conns Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary getroomservice/next.js rs/local-conns Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary getroomservice/next.js rs/local-conns Change
buildDuration 10.2s 10.2s ⚠️ +1ms
nodeModulesSize 82.4 MB 82.4 MB ⚠️ +40 B
Client Bundles (main, webpack, commons)
vercel/next.js canary getroomservice/next.js rs/local-conns Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-b992ce4..2479.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary getroomservice/next.js rs/local-conns Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary getroomservice/next.js rs/local-conns Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary getroomservice/next.js rs/local-conns Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary getroomservice/next.js rs/local-conns Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: e9591b8

@ijjk
Copy link
Member

ijjk commented Dec 13, 2020

Failing test suites

Commit: e9591b8

test/integration/dist-dir/test/index.test.js

  • distDir > should handle null/undefined distDir
Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 106

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

@timneutkens
Copy link
Member

Going to close this in favor of #20409. Thanks for the PR!

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next dev default listens on all interfaces
3 participants